Change in vdsm[master]: [WIP] Add the validateImage command to the SPM

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] Add the validateImage command to the SPM
......................................................................

[WIP] Add the validateImage command to the SPM

Signed-off-by: Federico Simoncelli 
Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sp.py
M vdsm/storage/volume.py
6 files changed, 60 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/3491/1
--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

Change in vdsm[master]: Add the validateImage command to the SPM

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2:

Why  you need it as API? Who goes to use it?

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: Add the validateImage command to the SPM

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 765:                 vol.validateMetadata()
why do you need to check each volume? 
'qemu-img check' can do it for whole chain if you check only the leaf

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: Add the validateImage command to the SPM

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: Add the validateImage command to the SPM
please explain why this new verb is required. after all, such validations are inherently raceful.

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: Add the validateImage command to the SPM

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/71/

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add the validateImage command to the SPM

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/71/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add the validateImage command to the SPM

Ayal Baron has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2: (2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 2121: 
Line 2122:         self.validateSdUUID(sdUUID)
Line 2123:         misc.validateUUID(imgUUID, 'imgUUID')
Line 2124: 
Line 2125:         vars.task.getSharedLock(STORAGE, sdUUID)
considering the issue with upgrade taking the lock for a long time, is this lock correct here?
Line 2126:         self._spmSchedule(spUUID, "validateImage",
Line 2127:                           pool.validateImage, sdUUID, imgUUID)
Line 2128: 
Line 2129:     @public

....................................................
File vdsm/storage/image.py
Line 761:         chain = self.prepare(sdUUID, imgUUID)
Line 762: 
Line 763:         try:
Line 764:             for vol in chain:
Line 765:                 vol.validateMetadata()
because each volume may potentially have different metadata?
Line 766:         finally:
Line 767:             self.teardown(sdUUID, imgUUID)
Line 768: 
Line 769:     def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID, dstVolUUID,

--
To view, visit http://gerrit.ovirt.org/3491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Add the validateImage command to the SPM

Itamar Heim has posted comments on this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Patch Set 2:

ping

Change in vdsm[master]: Add the validateImage command to the SPM

Itamar Heim has abandoned this change.

Change subject: Add the validateImage command to the SPM
......................................................................

Abandoned

abandoning - old. no reply. not touched for a while. please restore if relevant