6:03 a.m.
Shahar Havivi has uploaded a new change for review.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
vdsm: add support for ram/vram on QXL device
setting support for qxl device with proper ram/vram attributes:
1 Monitor, Single PCI checked 64MB 32MB
2 Monitors, Single PCI checked 132MB 32MB
4 Monitors, Single PCI checked 256MB 32MB
Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Bug-Url: https://bugzilla.redhat.com/787578
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M tests/vmTests.py
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/19361/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index b0675be..9aa9792 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -275,10 +275,10 @@
def testVideoXML(self):
videoXML = """
<video>
- <model heads="2" type="vga"
vram="8192"/>
+ <model heads="2" type="vga" vram="32768"
ram="131072"/>
</video>"""
- dev = {'device': 'vga', 'specParams': {'vram':
'8192', 'heads': '2'}}
+ dev = {'device': 'vga', 'specParams': {'vram':
'32768', 'ram': '65536' 'heads': '2'}}
video = vm.VideoDevice(self.conf, self.log, **dev)
self.assertXML(video.getXML(), videoXML)
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 92d274e..b378834 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1211,10 +1211,15 @@
Create domxml for video device
"""
video = self.createXmlElem('video', None, ['address'])
- video.appendChildWithArgs('model', type=self.device,
- vram=self.specParams['vram'],
- heads=self.specParams.get('heads',
'1'))
-
+ if 'ram' in self.specParams:
+ video.appendChildWithArgs('model', type=self.device,
+ vram=self.specParams.get('vram',
'32768'),
+ ram=self.specParams.get('ram',
'65536'),
+ heads=self.specParams.get('heads',
'1'))
+ else:
+ video.appendChildWithArgs('model', type=self.device,
+ vram=self.specParams.get('vram',
'32768'),
+ heads=self.specParams.get('heads',
'1'))
return video
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 27c12c1..f1a21ed 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2238,7 +2238,7 @@
#
# Since: 4.10.0
##
-{'type': 'VmVideoDeviceSpecParams', 'data': {'vram':
'uint', '*heads': 'uint'}}
+{'type': 'VmVideoDeviceSpecParams', 'data': {'vram':
'uint', 'ram': 'uint', '*heads': 'uint'}}
##
# @VmVideoDevice:
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
8:54 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:47 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Code-Review+1
The patch seems fine and safe, and quite localized, but I try to avoid non-bugfixes until
we get a stable master.
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:41 a.m.
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:36 a.m.
Martin Betak has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:24 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:18 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3809/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4694/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4618/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:07 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6:
(2 comments)
....................................................
Commit Message
Line 8:
Line 9: setting support for qxl device with proper ram/vram attributes:
Line 10:
Line 11: 1 Monitor, Single PCI checked 64MB 32MB
Line 12: 2 Monitors, Single PCI checked 132MB 32MB
132? Isn't it 128? Seems strange to me that it is 4MB more
Line 13: 4 Monitors, Single PCI checked 256MB 32MB
Line 14:
Line 15: Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Line 16: Bug-Url: https://bugzilla.redhat.com/787578
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2232: #
Line 2233: # @vram: value of virtual ram in KB, for 'cirrus' the default is
'9216'
Line 2234: # for @qxl is the size of the secondary bar,
Line 2235: #
Line 2236: # @ram: size of the primary bar for @qxl in KB,
Well vram is already in KB as well and was in KB already
But I am wondering if ram shouldn't be optional. Because it would break the API,
wouldn't it? At least this is how it is handled at the moment in the code.
Line 2237: # not supported for 'cirrus'
Line 2238: #
Line 2239: # @heads: #optional Specify the amount of monitors that will use single
Line 2240: # pci device. Currently relevant for @qxl devices only
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
12:27 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
vdsm: add support for ram/vram on QXL device
setting support for qxl device with proper ram/vram attributes:
1 Monitor, Single PCI checked 64MB 32MB
2 Monitors, Single PCI checked 128MB 32MB
4 Monitors, Single PCI checked 256MB 32MB
Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Bug-Url: https://bugzilla.redhat.com/787578
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/19361
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
Tested-by: Martin Betak <mbetak(a)redhat.com>
Reviewed-by: Martin Polednik <mpoledni(a)redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/vmTests.py
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 15 insertions(+), 8 deletions(-)
Approvals:
Saggi Mizrahi: Looks good to me, but someone else must approve
Federico Simoncelli: Looks good to me, but someone else must approve
Martin Betak: Verified
Dan Kenigsberg: Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:27 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 7: Code-Review+2
In a private communication Michal corrected me about this patch - it's not a new
feature, but a fix of a faulty ovirt-3.3.0 implementation. This makes this patch worthy of
our stabilization phase.
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:53 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6:
(1 comment)
Looks good, just a minor query
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2232: #
Line 2233: # @vram: value of virtual ram in KB, for 'cirrus' the default is
'9216'
Line 2234: # for @qxl is the size of the secondary bar,
Line 2235: #
Line 2236: # @ram: size of the primary bar for @qxl in KB,
why not have it be in bytes.
We use bytes for everything else.
We just document that we round of to the next block\sector\KB were appropriate.
Line 2237: # not supported for 'cirrus'
Line 2238: #
Line 2239: # @heads: #optional Specify the amount of monitors that will use single
Line 2240: # pci device. Currently relevant for @qxl devices only
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:07 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6: Code-Review+1
It seems straight forward (and at first sight it seems not to break live migration),
anyway I am not familiar enough with this part in order to give a +2 at this stage. Can
you verify it in the meantime?
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:42 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:27 p.m.
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:36 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4631/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4553/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3746/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:55 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 5: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4622/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4544/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3737/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:11 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4609/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4531/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3724/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:55 a.m.
Shahar Havivi has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 3:
(2 comments)
....................................................
File vdsm/vm.py
Line 1206: """
Line 1207: Create domxml for video device
Line 1208: """
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
Done
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
Done
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1215: else:
Line 1216: video.appendChildWithArgs('model', type=self.device,
Line 1217: vram=self.specParams.get('vram',
'32768'),
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
5:39 a.m.
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
....................................................
File vdsm/vm.py
Line 1206: """
Line 1207: Create domxml for video device
Line 1208: """
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
We could reduce code duplication by creating a dict
that holds parameters to be passed to final function
call:
sourceAttrs = {'vram': self.specParams.get('vram', '32768'),
'heads': self.specParams.get('heads', '1')}
if 'ram' in self.specParams:
sourceAttrs['ram'] = self.specParams.get('ram', '65536')
video.appendChildWithArgs('model', type=self.device, **sourceAttrs)
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
The default ram value could be removed as the parameter won't
be set unless it has been sent by engine: incorrect received value might
point to an issue in engine
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1215: else:
Line 1216: video.appendChildWithArgs('model', type=self.device,
Line 1217: vram=self.specParams.get('vram',
'32768'),
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:05 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4553/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4475/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3661/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:53 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4553/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3656/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4475/ : UNSTABLE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:11 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4505/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4424/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3608/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:04 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4504/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4423/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3607/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4553/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4475/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3664/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3861
days inactive
3873
days old
vdsm-patches@lists.fedorahosted.org
23 comments
9 participants
participants (9)
-
Dan Kenigsberg -
Federico Simoncelli -
Jenkins CI RO -
mbetak＠redhat.com -
michal.skrivanek＠redhat.com -
mpoledni＠redhat.com -
shavivi＠redhat.com -
smizrahi＠redhat.com -
Vinzenz Feenstra