Yaniv Bronhaim has posted comments on this change.
Change subject: generate qemu-kvm coredumps using abrt
......................................................................
Patch Set 7:
(6 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-10-30 16:02:10 +0200
Line 4: Commit: Mooli Tayer <mtayer(a)redhat.com>
Line 5: CommitDate: 2013-11-21 10:58:52 +0200
Line 6:
Line 7: generate qemu-kvm coredumps using abrt
I would say, removing core dump configuration from vdsm and start using abrt service as a
substitute
Line 8:
Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
....................................................
File init/systemd/vdsmd.service.in
Line 6: Conflicts=libvirt-guests.service ksmtuned.service
Line 7:
Line 8: [Service]
Line 9: Type=simple
Line 10: LimitCORE=infinity
is LimitCore can be removed too?
Line 11: EnvironmentFile=-/etc/sysconfig/vdsm
Line 12: ExecStartPre=@LIBEXECDIR(a)/vdsmd_init_common.sh --pre-start
Line 13: ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 /dev/null
"@VDSMDIR@/vdsm"
Line 14: ExecStopPost=@LIBEXECDIR(a)/vdsmd_init_common.sh --post-stop
....................................................
File init/sysvinit/vdsmd.init.in
Line 25: prog=vdsm
Line 26: PIDFILE=@VDSMRUNDIR(a)/vdsmd.pid
Line 27: RESPAWNPIDFILE=@VDSMRUNDIR(a)/respawn.pid
Line 28: NEEDED_SERVICES="iscsid multipathd rpcbind ntpd wdmd sanlock network
libvirtd
Line 29: supervdsmd abrtd"
should be stated also in init/upstart/vdsmd.upstart
Line 30: CONFLICTING_SERVICES="libvirt-guests ksmtuned"
Line 31: LOCK_FILE="/var/lock/subsys/vdsmd"
Line 32: VDSM_TOOL="@BINDIR@/vdsm-tool"
Line 33: NICE_LOWEST=-20
....................................................
File init/vdsmd_init_common.sh.in
Line 21
Line 22
Line 23
Line 24
Line 25
abrt conf should be configured? (
http://linux.die.net/man/5/abrt.conf)
....................................................
File lib/vdsm/config.py.in
Line 26
Line 27
Line 28
Line 29
Line 30
can't be that user will want to disable also the abrt's coredumps ?.. it might
consume some memory that can be important to some..
....................................................
File vdsm/vdsm
Line 163
Line 164
Line 165
Line 166
Line 167
does rlimit configure effects abrt? if is, should you initialize it?
--
To view, visit
http://gerrit.ovirt.org/20751
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes