Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#805273 Fix LVM preferred names ......................................................................
BZ#805273 Fix LVM preferred names
Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/3220/1 -- To view, visit http://gerrit.ovirt.org/3220 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Mark Wu has posted comments on this change.
Change subject: BZ#805273 Fix LVM preferred names ......................................................................
Patch Set 1:
BZ#805273 is not public, and I don't have permission to access it. Could you please describe the problem you're trying to fix in the commit message? Thanks!
-- To view, visit http://gerrit.ovirt.org/3220 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Igor Lvovsky has posted comments on this change.
Change subject: BZ#805273 Fix LVM preferred names ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3220 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#805273 Fix LVM preferred names ......................................................................
Patch Set 1: Verified
I have no idea why this lvm bug is set to private, and I quote "In the lvm2 release (2.02.95-2) the preferred_names option is ignored."
In any case, Federico's commit message should have been more descriptive.
-- To view, visit http://gerrit.ovirt.org/3220 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#805273 Fix LVM preferred names ......................................................................
BZ#805273 Fix LVM preferred names
Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3220 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ibaa71b784cfacdbc05677fdb37acf9a2ac11db0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org