Change in vdsm[master]: hsm.py: volUUID is not member of HSM class

Lukas Bednar has uploaded a new change for review.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

hsm.py: volUUID is not member of HSM class

Change-Id: I5adc1fb40d54b7a887a4aba44c8884c876d5613a
Signed-off-by: Lukas Bednar 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/24313/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 9420931..41917f3 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -692,7 +692,7 @@
         volFormat = volToExtend.getFormat()

if not volToExtend.isLeaf():
-            raise se.VolumeNonWritable(self.volUUID)
+            raise se.VolumeNonWritable(volUUID)

if volFormat != volume.COW_FORMAT:
             # This method is used only with COW volumes (see docstring),

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6299/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7189/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7078/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 1:

Could you explain in the commit message when was this introduced? We should understand how this went unnoticed and to where we should backport it.

Lukas Bednar has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 1:

I noticed this issue besides of [1]. I tried to run pylint on hsm.py module. and it showed up. I believe that there are more issues like that. and I would consider to deploy pylint as part of tests.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1059108

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6313/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7203/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7096/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2: Code-Review+2

checking python module: cpopen... no
configure: error: failed to find required module cpopen

You are right about the importance of running pylint in `make check-local`, but unfortunately, pylint currently gives plenty of false errors. We should first silence them all, or run `pylint -E` only on known-silent modules.

Daniel Erez has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2: Code-Review+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2: Code-Review+1

Itamar Heim has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2:

ping

Itamar Heim has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2:

why isn't this verified so it can be merged?

Lukas Bednar has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2:

how can I verify it? do you have some jenkins job where I can pass this change and run it ?

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2: Verified+1

This is a trivial change that does not require verification.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 2:

Lukas, using updateVolumeSize() on a leaf volume would have been a proper verification, just to see that nothing in the positive flow was broken.

But I tend to agree with Nir: this is obvious enough and simple enough and sideline enough to merit v-less merger.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

hsm.py: volUUID is not member of HSM class

this issues was found using static analysis of code.
it was causued by 24ad94dd, this change should be backported to all
branches which contains change mentioned above.

Change-Id: I5adc1fb40d54b7a887a4aba44c8884c876d5613a
Signed-off-by: Lukas Bednar 
Reviewed-on: http://gerrit.ovirt.org/24313
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Daniel Erez 
Reviewed-by: Nir Soffer 
Tested-by: Nir Soffer 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, but someone else must approve
  Daniel Erez: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hsm.py: volUUID is not member of HSM class
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5627/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3785/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1645/ : SUCCESS