Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47578
to review the following change.
Change subject: multiapth: Require newer multiapth version ......................................................................
multiapth: Require newer multiapth version
Multipath did not identify iscsi devices correctly, so their session recovery_tmo was not configured correctly. This caused slow failover when path is having trouble, and may lead to blocking of multiple vdsm threads for many minutes.
This issue was fixed in device-mapper-multipath in some of the supported platforms:
platform version #bug available ------------------------------------------------------------------ RHEL 7.2 0.4.9-82.el7 bz1254292 yes RHEL 7.1 0.4.9-77.el7_1.2 bz1267131 yes Fedora 22 0.4.9-73.fc22.1 bz1256074 yes Fedora 21 0.4.9-68.fc21.6 bz1261141 no CentOS na na no
We require now new version where it is available. We will update the requirement when the fix is available on other platforms.
Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd Bug-Url: https://bugzilla.redhat.com/1255173 Bug-Url: https://bugzilla.redhat.com/1256081 Backport-To: 3.6 Backport-To: 3.5 Relates-To: https://bugzilla.redhat.com/880738 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/45115 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/47578/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 6cbd119..e05be56 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -176,7 +176,11 @@ Requires: sanlock >= 2.8, sanlock-python
%if 0%{?rhel} +%if 0%{centos} Requires: device-mapper-multipath >= 0.4.9-68 +%else +Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2 +%endif Requires: e2fsprogs Requires: fence-agents-all %if 0%{?centos} @@ -194,7 +198,11 @@ # Subprocess and thread bug was found on python 2.7.2 Requires: python >= 2.7.3 Requires: initscripts >= 9.42.2-1 +%if 0%{?fedora} >= 22 +Requires: device-mapper-multipath >= 0.4.9-73.fc22.1 +%else Requires: device-mapper-multipath >= 0.4.9-56 +%endif Requires: e2fsprogs >= 1.41.14 Requires: policycoreutils-python Requires: sed >= 4.2.1-10
automation@ovirt.org has posted comments on this change.
Change subject: multiapth: Require newer multiapth version ......................................................................
Patch Set 1:
* Update tracker::#1255173::OK * Update tracker::#1256081::OK * Check Bug-Url::OK * Check Public Bug::#1255173::OK, public bug * Check Public Bug::#1256081::OK, public bug * Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1256081::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: multiapth: Require newer multiapth version ......................................................................
Patch Set 1: Verified+1
Verified on master.
Francesco Romani has posted comments on this change.
Change subject: multiapth: Require newer multiapth version ......................................................................
Patch Set 1: Code-Review+2
Francesco Romani has submitted this change and it was merged.
Change subject: multiapth: Require newer multiapth version ......................................................................
multiapth: Require newer multiapth version
Multipath did not identify iscsi devices correctly, so their session recovery_tmo was not configured correctly. This caused slow failover when path is having trouble, and may lead to blocking of multiple vdsm threads for many minutes.
This issue was fixed in device-mapper-multipath in some of the supported platforms:
platform version #bug available ------------------------------------------------------------------ RHEL 7.2 0.4.9-82.el7 bz1254292 yes RHEL 7.1 0.4.9-77.el7_1.2 bz1267131 yes Fedora 22 0.4.9-73.fc22.1 bz1256074 yes Fedora 21 0.4.9-68.fc21.6 bz1261141 no CentOS na na no
We require now new version where it is available. We will update the requirement when the fix is available on other platforms.
Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd Bug-Url: https://bugzilla.redhat.com/1255173 Bug-Url: https://bugzilla.redhat.com/1256081 Backport-To: 3.6 Backport-To: 3.5 Relates-To: https://bugzilla.redhat.com/880738 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/45115 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/47578 Reviewed-by: Francesco Romani fromani@redhat.com --- M vdsm.spec.in 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: multiapth: Require newer multiapth version ......................................................................
Patch Set 2:
* Update tracker::#1255173::OK * Update tracker::#1256081::OK * Set MODIFIED::bug 1255173::::#1255173::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager * Set MODIFIED::bug 1255173::::bug 1256081::::#1256081::::IGNORE, not oVirt prod but vdsm
vdsm-patches@lists.fedorahosted.org