5:39 a.m.
Hello Yeela Kaplan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39312
to review the following change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Restart supervdsmd service always and not only on-abort
Currently we restart the service only after SIGKILL (on-abort) but the
desire behaviour should be always restarts when the process goes down.
Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39104
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M init/systemd/supervdsmd.service.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/39312/1
diff --git a/init/systemd/supervdsmd.service.in b/init/systemd/supervdsmd.service.in
index 9d3fa7d..7a5e871 100644
--- a/init/systemd/supervdsmd.service.in
+++ b/init/systemd/supervdsmd.service.in
@@ -7,4 +7,4 @@
LimitCORE=infinity
EnvironmentFile=-/etc/sysconfig/supervdsmd
ExecStart=@VDSMDIR@/daemonAdapter "@VDSMDIR@/supervdsmServer" --sockfile
"@VDSMRUNDIR(a)/svdsm.sock"
-Restart=on-abort
+Restart=always
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
5:39 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:39 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-HasComments: No
1:07 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-HasComments: No
1:07 a.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Restart supervdsmd service always and not only on-abort
Currently we restart the service only after SIGKILL (on-abort) but the
desire behaviour should be always restarts when the process goes down.
Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39104
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39312
---
M init/systemd/supervdsmd.service.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
1:07 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
1:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
Build Started (1/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/203/
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
Build Started (2/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/28/
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
Build Started (3/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/203/
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
Build Started (4/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/197/
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:27 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Restart supervdsmd service always and not only on-abort
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/203/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/28/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/203/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/197/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/39312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3313
days inactive
3316
days old
vdsm-patches@lists.fedorahosted.org
10 comments
3 participants
participants (3)
-
automation＠ovirt.org -
Jenkins CI RO -
ybronhei＠redhat.com