Change in vdsm[ovirt-3.4]: fencing: stop using a deprecated command

[Dan Kenigsberg]

Hello Douglas Schilling Landgraf, Eli Mesika,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/24343

to review the following change.

Change subject: fencing: stop using a deprecated command
......................................................................

fencing: stop using a deprecated command

Recently, fence-agents stopped supporting the "option" alias for its
"action" STDIN command.

https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/00309...

Let us conform to the new option name. The "action" name has been long
supported by el6 and f19's fence-agents, so it can be safely used.

Thanks to John Taylor for reporting the issue.

Bug-Url: https://bugzilla.redhat.com/1063472
Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/24303
Reviewed-by: Eli Mesika 
Reviewed-by: Douglas Schilling Landgraf 
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/24343/1

diff --git a/vdsm/API.py b/vdsm/API.py
index 8c5b9cb..7cff71b 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1142,7 +1142,7 @@
                 return errCode['fenceAgent']
             raise

-        inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n'
+        inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
                'passwd=%s\n') % (agent, addr, username, action, password)
         if port != '':
             inp += 'port=%s\n' % (port,)

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: fencing: stop using a deprecated command
......................................................................

Patch Set 1: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fencing: stop using a deprecated command
......................................................................

Patch Set 1: Verified+1 Code-Review+1

Verified https://bugzilla.redhat.com/show_bug.cgi?id=1063472#c4

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fencing: stop using a deprecated command
......................................................................

Patch Set 1: -Code-Review

Yaniv Bronhaim has posted comments on this change.

Change subject: fencing: stop using a deprecated command
......................................................................

Patch Set 1: Code-Review+2

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: fencing: stop using a deprecated command
......................................................................

fencing: stop using a deprecated command

Recently, fence-agents stopped supporting the "option" alias for its
"action" STDIN command.

https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/00309...

Let us conform to the new option name. The "action" name has been long
supported by el6 and f19's fence-agents, so it can be safely used.

Thanks to John Taylor for reporting the issue.

Bug-Url: https://bugzilla.redhat.com/1063472
Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Signed-off-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/24303
Reviewed-by: Eli Mesika 
Reviewed-by: Douglas Schilling Landgraf 
Reviewed-on: http://gerrit.ovirt.org/24343
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Verified