Change in vdsm[master]: core: report cpuUser and cpuSys separately

Laszlo Hornyak has uploaded a new change for review.

Change subject: core: report cpuUser and cpuSys separately
......................................................................

core: report cpuUser and cpuSys separately

Uses virDomainGetCPUStats to get the CPU information instead of info()

Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
---
M vdsm/libvirtvm.py
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/5793/1
--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;

Laszlo Hornyak has abandoned this change.

Change subject: core: report cpuUser and cpuSys separately
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: report cpuUser and cpuSys separately
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/165/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: report cpuUser and cpuSys separately
......................................................................


Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/165/

--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: core: report cpuUser and cpuSys separately
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 183:         stats['cpuSys'] = 0.0
oh, and I suppose you won't need this line ^^^

--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: core: report cpuUser and cpuSys separately
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 187:             stats['cpuUser'] = sInfo['user_time'] / 1000**3
I doubt that using only the start sample is enough.

What are the units in which user_time is reported by getCPUStats?

Line 191:             self._log.debug(e)
If you really want to add 'e' to the logs, better put it in the former .debug()
string. Otherwise they may be interleaved by other log messages.

--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff1e2babfa9675155072b553c38db9411e3ddd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;