11:16 a.m.
Hans De Goede has uploaded a new change for review.
Change subject: vm.py: Fix legacy disk support
......................................................................
vm.py: Fix legacy disk support
Creating vms with legacy disk parameters, ie hda=/path/disk.img would fail
with a backtrace in clientIF:prepareVolumePath() with a missing attribute
error for drive['device'], while at it also setup type properly (not strictly
necessary, since getConfDrives will fill this in otherwise).
Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Signed-off-by: Hans de Goede <hdegoede(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/4093/1
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
3:28 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm.py: Fix legacy disk support
......................................................................
vm.py: Fix legacy disk support
Creating vms with legacy disk parameters, ie hda=/path/disk.img would fail
with a backtrace in clientIF:prepareVolumePath() with a missing attribute
error for drive['device'], while at it also setup type properly (not strictly
necessary, since getConfDrives will fill this in otherwise).
Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Signed-off-by: Hans de Goede <hdegoede(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Hans De Goede: Verified
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
10:17 a.m.
Hans De Goede has posted comments on this change.
Change subject: vm.py: Fix legacy disk support
......................................................................
Patch Set 1: Verified
Tested and works for me.
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:56 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vm.py: Fix legacy disk support
......................................................................
Patch Set 1:
Please tick Verified after checking that this indeed fixes the issue.
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:55 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vm.py: Fix legacy disk support
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
8:11 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vm.py: Fix legacy disk support
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:17 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: vm.py: Fix legacy disk support
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb9fa19b95bba6fdbed29c7829e633289c0e0fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4371
days inactive
4376
days old
vdsm-patches@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Hans de Goede -
Igor Lvovsky