Change in vdsm[master]: Reuse the stored pool host id on reconstructMaster

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................

Reuse the stored pool host id on reconstructMaster

When the SPM is unable to reach the master domain the VDSM process
might be fenced (killed) by safelease or sanlock.
The engine will try to reconstruct the master and VDSM would use
a temporary id (eg: 250) to execute the operation. This patch uses
the information stored by connectStoragePool to acquire the same
host id that was in use before VDSM restarted.

Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/4965/1
--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Itamar Heim has abandoned this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/111/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/111/

--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Patch Set 1:

still relevant?

-- 
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 203:     def _acquireHostId(self, sdUUID, isValid):
It's quite a while that I try to remove it. Please refer to:

 http://gerrit.ovirt.org/#/c/3929/

Line 496:     def _acquireTemporaryClusterLock(self, msdUUID, safeLease, hostId=None):
We might want to leave this alone (using it only in create for now and eventually get rid
of it later) and then require the proper hostId in reconstructMaster..

--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Ayal Baron has posted comments on this change.

Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 203:     def _acquireHostId(self, sdUUID, isValid):
Why is this function here? it is never used?

Line 496:     def _acquireTemporaryClusterLock(self, msdUUID, safeLease, hostId=None):
Reading this now it appears to me as though this function is misnamed as it doesn't
make the cluster lock temporary at all, it is just *used* this way by the calling
function.
Also, since we cannot reliably determine the host id I'm starting to think that the
annoyance here outgrows the benefit and maybe we should just get rid of this
'protection' altogether, or at least get rid of the call in create and just use
this in reconstructMaster (and then inline the funcion as I have no idea what to name it
:)

--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;