Change in vdsm[master]: functional net test: set both bridge_opts and ethtool_opts

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................

functional net test: set both bridge_opts and ethtool_opts

This test has been written in an attempt to reproduce the referred bug,
to no avail.

Bug-Url: https://bugzilla.redhat.com/1186203
Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/functional/networkTests.py
1 file changed, 42 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/39251/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 8671244..81218fe 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2394,3 +2394,45 @@
             self.assertNetworkDoesntExist(NETWORK_NAME)
             self.assertBondDoesntExist(BONDING_NAME, [nic])
             self.vdsm_net.save_config()
+
+    @cleanupNet
+    @ValidateRunningAsRoot
+    def test_ethtool_bridge_opts(self):
+        status, msg, info = self.vdsm_net.getVdsCapabilities()
+        self.assertEqual(status, SUCCESS, msg)
+        if '30_ethtool_options' not in
info['hooks']['after_network_setup']:
+            raise SkipTest('ethtool hook not installed')
+
+        def get_gso(nic):
+            GSO = 'generic-segmentation-offload:'
+            rc, out, err = execCmd(['ethtool', '-k', nic])
+            self.assertTrue(rc == 0, 'error reading gso: %s' % err)
+            for line in out:
+                if line.startswith(GSO):
+                    return line[len(GSO) + 1:]
+
+        def setup_bridge_and_eth_opts(nic, priority, gso):
+            bridge_opts = {'priority': priority}
+            custom = {
+                'bridge_opts': 'priority=' + priority,
+                'ethtool_opts': '-K * gso ' + gso
+            }
+
+            status, msg = self.vdsm_net.setupNetworks(
+                {NETWORK_NAME: {'nic': nic, 'bridged': True,
+                                'vlan': VLAN_ID,
+                                'custom': custom}},
+                {}, NOCHK)
+            self.assertEqual(status, SUCCESS, msg)
+            self.assertNetworkExists(NETWORK_NAME, bridgeOpts=bridge_opts)
+            self.assertEqual(get_gso(nic), gso)
+
+        with dummyIf(1) as (nic, ):
+            setup_bridge_and_eth_opts(nic, '42', 'on')
+            setup_bridge_and_eth_opts(nic, '33', 'off')
+
+            status, msg = self.vdsm_net.setupNetworks(
+                {NETWORK_NAME: {'remove': True}},
+                {}, NOCHK)
+            self.assertEqual(status, SUCCESS, msg)
+            self.assertNetworkDoesntExist(NETWORK_NAME)


-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

* Update tracker::#1186203::OK
* Check Bug-Url::OK
* Check Public Bug::#1186203::OK, public bug
* Check Product::#1186203::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

Build Started (1/3) ->
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/...

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17197/

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

Build Started (3/3) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17371/

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17197/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17371/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : There was
an infra issue, please contact infra(a)ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Abandoned

the bug cannot reproduce; the test is not interesting enough on its own right.

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: functional net test: set both bridge_opts and ethtool_opts
......................................................................


Patch Set 1:

* Update tracker::#1186203::OK

-- 
To view, visit https://gerrit.ovirt.org/39251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dd7fa0a05e83ab37393651f23cdf9b7e08ed89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No