Vinzenz Feenstra has uploaded a new change for review.
Change subject: Move virt things into vdsm/virt ......................................................................
Move virt things into vdsm/virt
Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com --- M configure.ac M tests/guestIFTests.py M tests/vmTests.py M vdsm.spec.in M vdsm/API.py M vdsm/Makefile.am M vdsm/clientIF.py A vdsm/virt/Makefile.am A vdsm/virt/__init__.py R vdsm/virt/guestIF.py R vdsm/virt/sampling.py R vdsm/virt/vm.py R vdsm/virt/vmChannels.py R vdsm/virt/vmstatus.py 14 files changed, 45 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/21792/1
diff --git a/configure.ac b/configure.ac index 4ba4a9e..6d72726 100644 --- a/configure.ac +++ b/configure.ac @@ -273,6 +273,7 @@ vdsm/storage/imageRepository/Makefile vdsm/storage/protect/Makefile vdsm/storage/vdsm-lvm.rules + vdsm/virt/Makefile vdsm_api/Makefile vdsm_hooks/Makefile vdsm_hooks/checkimages/Makefile diff --git a/tests/guestIFTests.py b/tests/guestIFTests.py index 94efe92..1a6e6d2 100644 --- a/tests/guestIFTests.py +++ b/tests/guestIFTests.py @@ -20,7 +20,7 @@ # import logging from collections import namedtuple -import guestIF +from virt import guestIF import json
from testrunner import VdsmTestCase as TestCaseBase diff --git a/tests/vmTests.py b/tests/vmTests.py index 1f69f0a..b7ec102 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -22,7 +22,7 @@ import tempfile import xml.etree.ElementTree as ET
-import vm +from virt import vm from vdsm import constants from testrunner import VdsmTestCase as TestCaseBase import caps diff --git a/vdsm.spec.in b/vdsm.spec.in index ca02046..1d2f87b 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -832,6 +832,7 @@ %dir %{_datadir}/%{vdsm_name}/netconf %dir %{_datadir}/%{vdsm_name}/storage %dir %{_datadir}/%{vdsm_name}/storage/imageRepository +%dir %{_datadir}/%{vdsm_name}/virt %{_datadir}/%{vdsm_name}/alignmentScan.py* %{_datadir}/%{vdsm_name}/blkid.py* %{_datadir}/%{vdsm_name}/caps.py* @@ -850,7 +851,8 @@ %{_datadir}/%{vdsm_name}/sourceRouteThread.py* %{_datadir}/%{vdsm_name}/supervdsm.py* %{_datadir}/%{vdsm_name}/supervdsmServer -%{_datadir}/%{vdsm_name}/vmChannels.py* +%{_datadir}/%{vdsm_name}/virt/__init__.py* +%{_datadir}/%{vdsm_name}/virt/vmChannels.py* %{_datadir}/%{vdsm_name}/vmstatus.py* %{_datadir}/%{vdsm_name}/tc.py* %{_datadir}/%{vdsm_name}/vdsm @@ -874,7 +876,7 @@ %{_sysconfdir}/sudoers.d/50_vdsm %{_sysconfdir}/cron.hourly/vdsm-logrotate %{_sysconfdir}/cron.d/vdsm-libvirt-logrotate -%{_datadir}/%{vdsm_name}/guestIF.py* +%{_datadir}/%{vdsm_name}/virt/guestIF.py* %{_datadir}/%{vdsm_name}/logUtils.py* %{_datadir}/%{vdsm_name}/dsaversion.py* %{_libexecdir}/%{vdsm_name}/curl-img-wrap @@ -992,7 +994,7 @@ %{_datadir}/%{vdsm_name}/neterrors.py* %{_datadir}/%{vdsm_name}/netmodels.py* %{_datadir}/%{vdsm_name}/respawn -%{_datadir}/%{vdsm_name}/sampling.py* +%{_datadir}/%{vdsm_name}/virt/sampling.py* %{_datadir}/%{vdsm_name}/set-conf-item %if 0%{?with_gluster} %dir %{_datadir}/%{vdsm_name}/gluster diff --git a/vdsm/API.py b/vdsm/API.py index 9b722a2..a998e71 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -40,8 +40,8 @@ import storage.volume import storage.sd import storage.image -import vm -import vmstatus +from virt import vm +from virt import vmstatus from vdsm.define import doneCode, errCode, Kbytes, Mbytes import caps from vdsm.config import config diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index 2dc0876..45ea118 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -18,7 +18,7 @@ # Refer to the README and COPYING files for full details of the license #
-SUBDIRS = netconf sos storage gluster +SUBDIRS = netconf sos storage gluster virt
include $(top_srcdir)/build-aux/Makefile.subs
@@ -32,7 +32,6 @@ configNetwork.py \ debugPluginClient.py \ dmidecodeUtil.py \ - guestIF.py \ hooking.py \ hooks.py \ kaxmlrpclib.py \ @@ -51,9 +50,6 @@ supervdsm.py \ tc.py \ vdsmDebugPlugin.py \ - vmChannels.py \ - vm.py \ - vmstatus.py \ $(NULL)
dist_vdsmexec_SCRIPTS = \ diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index f65e556..f8266e3 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -35,16 +35,16 @@ from vdsm.define import doneCode, errCode import libvirt from vdsm import libvirtconnection -import vm +from virt import vm from vdsm import constants from vdsm import utils from netconf import ifcfg import caps -from vmChannels import Listener -from vm import Vm +from virt.vmChannels import Listener +from virt.vm import Vm import blkid import supervdsm -import sampling +from virt import sampling import vmstatus try: import gluster.api as gapi diff --git a/vdsm/virt/Makefile.am b/vdsm/virt/Makefile.am new file mode 100644 index 0000000..4b4f21b --- /dev/null +++ b/vdsm/virt/Makefile.am @@ -0,0 +1,30 @@ +# +# Copyright 2013 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +include $(top_srcdir)/build-aux/Makefile.subs + +vdsm_virtdir = $(vdsmdir)/virt +dist_vdsm_virt_PYTHON = \ + guestIF.py \ + sampling.py \ + vm.py \ + vmChannels.py \ + vmstatus.py \ + $(NULL) diff --git a/vdsm/virt/__init__.py b/vdsm/virt/__init__.py new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/vdsm/virt/__init__.py diff --git a/vdsm/guestIF.py b/vdsm/virt/guestIF.py similarity index 100% rename from vdsm/guestIF.py rename to vdsm/virt/guestIF.py diff --git a/vdsm/sampling.py b/vdsm/virt/sampling.py similarity index 100% rename from vdsm/sampling.py rename to vdsm/virt/sampling.py diff --git a/vdsm/vm.py b/vdsm/virt/vm.py similarity index 100% rename from vdsm/vm.py rename to vdsm/virt/vm.py diff --git a/vdsm/vmChannels.py b/vdsm/virt/vmChannels.py similarity index 100% rename from vdsm/vmChannels.py rename to vdsm/virt/vmChannels.py diff --git a/vdsm/vmstatus.py b/vdsm/virt/vmstatus.py similarity index 100% rename from vdsm/vmstatus.py rename to vdsm/virt/vmstatus.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4938/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5738/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5827/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4939/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5739/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5828/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4941/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5741/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5830/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 3: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4942/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5742/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5831/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4945/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5745/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5835/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4946/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5746/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5836/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4947/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5747/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5837/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6576/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5683/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6488/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/215/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6578/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5685/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6491/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/216/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 7:
At glance looks fine (deeper review later). I think this is a pretty good step in the right direction, I like it very much.
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 7: Code-Review+1
Looks fine.
Martin Polednik has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 7: Code-Review+1
much needed patch, seems okay
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 7: Code-Review-1
The code looks good to me but needs a rebase cherry-pick failed.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 8: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6207/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/330/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7097/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/122/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/61/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/6986/ : UNSTABLE
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 8: Code-Review+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 8: -Code-Review
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6278/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/138/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7168/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/77/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7057/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/337/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 8: -Verified
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7465/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/383/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6674/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7575/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6832/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7622/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7732/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/404/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6833/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7623/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7733/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/405/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
I had the chance to run this code together with 21790 and some other minor unrelated patches.
I did: * (intense) test of VM startup/shutdown during benchmarking * recovering: started a VM, restarted VDSM while VM was running * migration source/destination * suspension (hibernation) and re-starting from suspension.
Let me know if this can be enough for verification or, if not, if I can help with some more tests.
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10: Code-Review+1
considering also my previous comment, looks OK.
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
tested on ISCSI (block storage).
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10: Verified+1
re-run same as for my previous comment tests on NFS storage, ticking verified.
Dan Kenigsberg has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
(1 comment)
Thanks!
http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py File vdsm/clientIF.py:
Line 35: from virt import vm Line 36: from vdsm import constants Line 37: from vdsm import utils Line 38: import caps Line 39: from virt.vmChannels import Listener let's use this opportunity to rename the vmChannels to vmchannles. Line 40: from virt.vm import Vm Line 41: import blkid Line 42: import supervdsm Line 43: from virt import sampling
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10: Code-Review-1
(7 comments)
Some minor changes.
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py* Line 934: %{_datadir}/%{vdsm_name}/vdsm Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py* Please put the virt package together. Lines: - 910, - 930-932 - 937-939 - 960 - 1083 are the same package. Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py* Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py* Line 940: Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am File vdsm/virt/Makefile.am:
Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. 2014 for now ;-) Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py File vdsm/virt/__init__.py:
Line 1 Missing copyright notice for this beautiful blank line.
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py File vdsm/virt/guestIF.py:
Line 25: import json Line 26: import supervdsm Line 27: import unicodedata Line 28: Line 29: import vmstatus now that this is the virt package, this line should be from . import vmstatus Line 30: Line 31: _MAX_SUPPORTED_API_VERSION = 0 Line 32: _IMPLICIT_API_VERSION_ZERO = 0 Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 54: import caps Line 55: import guestIF Line 56: import hooks Line 57: import kaxmlrpclib Line 58: import sampling from . import sampling Line 59: import supervdsm Line 60: import vmexitreason Line 61: import vmstatus Line 62:
Line 57: import kaxmlrpclib Line 58: import sampling Line 59: import supervdsm Line 60: import vmexitreason Line 61: import vmstatus from . import vmstatus
And for the rest of imports of the virt package, the same. Line 62: Line 63: from vmpowerdown import VmShutdown, VmReboot Line 64: Line 65: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm'
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py File vdsm/virt/vmChannels.py:
Line 1: # Line 2: # Copyright 2012 Red Hat, Inc. This file has been modified after 2012 IIRC Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6900/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7690/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/420/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7802/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 10:
(6 comments)
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in File vdsm.spec.in:
Line 933: %{_datadir}/%{vdsm_name}/tc.py* Line 934: %{_datadir}/%{vdsm_name}/vdsm Line 935: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config Line 936: %{_datadir}/%{vdsm_name}/vdsm-store-net-config Line 937: %{_datadir}/%{vdsm_name}/virt/vm.py*
Please put the virt package together. Lines:
true true, and then again in this file is no order at all here Line 938: %{_datadir}/%{vdsm_name}/virt/vmexitreason.py* Line 939: %{_datadir}/%{vdsm_name}/virt/vmpowerdown.py* Line 940: Line 941: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py File vdsm/clientIF.py:
Line 35: from virt import vm Line 36: from vdsm import constants Line 37: from vdsm import utils Line 38: import caps Line 39: from virt.vmChannels import Listener
let's use this opportunity to rename the vmChannels to vmchannles.
The follow up commit for this has been submitted as: http://gerrit.ovirt.org/26192 Line 40: from virt.vm import Vm Line 41: import blkid Line 42: import supervdsm Line 43: from virt import sampling
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/Makefile.am File vdsm/virt/Makefile.am:
Line 1: # Line 2: # Copyright 2013 Red Hat, Inc.
2014 for now ;-)
The patch was originally done 2013, if at all we should update this to 2013-2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/__init__.py File vdsm/virt/__init__.py:
Line 1
Missing copyright notice for this beautiful blank line.
Yay let's copyright all the blank files on this planet!
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/guestIF.py File vdsm/virt/guestIF.py:
Line 25: import json Line 26: import supervdsm Line 27: import unicodedata Line 28: Line 29: import vmstatus
now that this is the virt package, this line should be
yes Line 30: Line 31: _MAX_SUPPORTED_API_VERSION = 0 Line 32: _IMPLICIT_API_VERSION_ZERO = 0 Line 33:
http://gerrit.ovirt.org/#/c/21792/10/vdsm/virt/vmChannels.py File vdsm/virt/vmChannels.py:
Line 1: # Line 2: # Copyright 2012 Red Hat, Inc.
This file has been modified after 2012 IIRC
Unrelated to this patch though, but yes Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6903/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7694/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/423/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7806/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 12: Code-Review+1
Thanks Vinzenz!
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 12: Code-Review+1 Verified+1
the last changes seem to me small enough to not need to another round of testing, thus I'm reticking the verify flag.
Let me know if some test has to be redone.
Dan Kenigsberg has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 12: Code-Review+2
I think it's safe enough, too.
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 13: Code-Review+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6907/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7697/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/426/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7809/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 13: Verified+1
re-verified using functional tests
http://paste.fedoraproject.org/89516/
some glitches reported, but look unrelated, thus ticking verified.
Dan Kenigsberg has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 13: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move virt things into vdsm/virt ......................................................................
Move virt things into vdsm/virt
Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com Reviewed-on: http://gerrit.ovirt.org/21792 Reviewed-by: Antoni Segura Puimedon asegurap@redhat.com Tested-by: Francesco Romani fromani@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M configure.ac M debian/vdsm.install M tests/clientifTests.py M tests/functional/storageTests.py M tests/functional/virtTests.py M tests/guestIFTests.py M tests/vmTests.py M vdsm.spec.in M vdsm/API.py M vdsm/Makefile.am M vdsm/clientIF.py A vdsm/virt/Makefile.am A vdsm/virt/__init__.py R vdsm/virt/guestIF.py R vdsm/virt/sampling.py R vdsm/virt/vm.py R vdsm/virt/vmChannels.py R vdsm/virt/vmexitreason.py R vdsm/virt/vmpowerdown.py R vdsm/virt/vmstatus.py 20 files changed, 101 insertions(+), 44 deletions(-)
Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/429/ : SUCCESS
vdsm-patches@lists.fedorahosted.org