11:14 a.m.
ShaoHe Feng has uploaded a new change for review.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Clean the RHEVM parser help in deployUtil.py.in
Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/3838/1
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
11:30 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
3:37 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
12:25 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: Verified
Tested in a Fedora 16 x86_64 SMP. The @ENGINENAME@ is substituted for string literal
'oVirt Engine' in the generated deployUtil.py. The patch works effectively.
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
12:33 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1467
Does "--download-rhevm-cert" need to be cleaned as well in another patch?
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
1:43 a.m.
ShaoHe Feng has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1467
I think so. we should add an new AC_SUBST Marco in the configure.ac to substitute it. also
there are some functions and variables, we should be carefully to substitute them.
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:40 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1467
I think changing the command option name and function name can be very confusing to users.
Command option and function names ought to be stable between releases and different engine
setup. Can we just remove the "rhevm" from the name?
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:16 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1467
this command line is not really used by human users - you can (and should) remove the
"rhevm" string from it, but you must make sure that all users agree about the
new name. if it turns out that an older version needs it, you can add a option - but I do
not think this is the case.
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:16 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Clean the RHEVM parser help in deployUtil.py.in
Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Zhou Zheng Sheng: Verified
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
4371
days inactive
4388
days old
vdsm-patches@lists.fedorahosted.org
8 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
shaohef＠linux.vnet.ibm.com -
zhshzhou＠linux.vnet.ibm.com