Francesco Romani has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 1: Code-Review+1 Verified+1
I don't know a better way to fix this, and this solves my reproducer:
VDSM:
Thread-100::DEBUG::2014-11-13
13:05:38,935::__init__::502::jsonrpc.JsonRpcServer::(_serveRequest) Return
'VM.cont' in bridge with {'vmList': {}}
Thread-100::DEBUG::2014-11-13 13:05:38,935::__init__::143::root::(encode) sending back:
{"jsonrpc": "2.0", "id":
"4a653b70-05ca-4c4d-a70f-92ded559e43f", "result": {"vmList":
{}}}
Thread-100::DEBUG::2014-11-13
13:05:38,935::stompReactor::163::yajsonrpc.StompServer::(send) Sending response
libvirtEventLoop::DEBUG::2014-11-13 13:05:39,010::vm::5381::vm.Vm::(_logGuestCpuStatus)
vmId=`2ba1a9eb-5843-466a-a5e5-530a9c06447b`::CPU running: onResume
libvirtEventLoop::DEBUG::2014-11-13
13:05:39,010::vm::4919::vm.Vm::(_onLibvirtLifecycleEvent)
vmId=`2ba1a9eb-5843-466a-a5e5-530a9c06447b`::event Resumed detail 0 opaque None
libvirtEventLoop::DEBUG::2014-11-13 13:05:39,011::vm::5381::vm.Vm::(_logGuestCpuStatus)
vmId=`2ba1a9eb-5843-466a-a5e5-530a9c06447b`::CPU running: onResume
JsonRpc (StompReactor)::DEBUG::2014-11-13
13:05:39,208::stompReactor::98::Broker.StompAdapter::(handle_frame) Handling message
<StompFrame command='SEND'>
JsonRpcServer::DEBUG::2014-11-13
13:05:39,209::__init__::508::jsonrpc.JsonRpcServer::(serve_requests) Waiting for request
Engine:
2014-11-13 13:05:38,194 INFO [org.ovirt.engine.core.bll.RunVmCommand]
(http--0.0.0.0-8080-4) [668a01e3] Lock Acquired to object 'EngineLock [exclusiveLocks=
key: 2ba1a9eb-5843-466a-a5e5-530a9c06447b value: VM
, sharedLocks= ]'
2014-11-13 13:05:38,318 INFO [org.ovirt.engine.core.bll.RunVmCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] Running command: RunVmCommand internal:
false. Entities affected : ID: 2ba1a9eb-5843-466a-a5e5-530a9c06447b Type: VMAction group
VM_BASIC_OPERATIONS with role type USER
2014-11-13 13:05:38,324 INFO [org.ovirt.engine.core.vdsbroker.ResumeVDSCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] START, ResumeVDSCommand(HostName = toji,
HostId = 4afae575-0864-4583-93a7-e67d4e4de4ba, vmId=2ba1a9eb-5843-466a-a5e5-530a9c06447b),
log id: 64a8a0af
2014-11-13 13:05:38,330 INFO
[org.ovirt.engine.core.vdsbroker.vdsbroker.ResumeBrokerVDSCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] START, ResumeBrokerVDSCommand(HostName =
toji, HostId = 4afae575-0864-4583-93a7-e67d4e4de4ba,
vmId=2ba1a9eb-5843-466a-a5e5-530a9c06447b), log id: 17d5fe23
2014-11-13 13:05:38,408 INFO
[org.ovirt.engine.core.vdsbroker.vdsbroker.ResumeBrokerVDSCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] FINISH, ResumeBrokerVDSCommand, log id:
17d5fe23
2014-11-13 13:05:38,410 INFO [org.ovirt.engine.core.vdsbroker.ResumeVDSCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] FINISH, ResumeVDSCommand, return:
PoweringUp, log id: 64a8a0af
2014-11-13 13:05:38,412 INFO [org.ovirt.engine.core.bll.RunVmCommand]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] Lock freed to object 'EngineLock
[exclusiveLocks= key: 2ba1a9eb-5843-466a-a5e5-530a9c06447b value: VM
, sharedLocks= ]'
2014-11-13 13:05:38,459 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(org.ovirt.thread.pool-8-thread-37) [668a01e3] Correlation ID: 668a01e3, Job ID:
dcdb5701-e484-4482-a3a6-0672a2dab68f, Call Stack: null, Custom Event ID: -1, Message: VM
NS_C001 was resumed by admin (Host: toji).
2014-11-13 13:05:38,685 INFO [org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo]
(DefaultQuartzScheduler_Worker-99) [] VM NS_C001 2ba1a9eb-5843-466a-a5e5-530a9c06447b
moved from Paused --> PoweringUp
2014-11-13 13:06:16,483 INFO [org.ovirt.engine.core.bll.SetVmTicketCommand]
(http--0.0.0.0-8080-4) [2310d22d] Running command: SetVmTicketCommand internal: false.
Entities affected : ID: 2ba1a9eb-5843-466a-a5e5-530a9c06447b Type: VMAction group
CONNECT_TO_VM with role type USER
2014-11-13 13:06:16,503 INFO
[org.ovirt.engine.core.vdsbroker.vdsbroker.SetVmTicketVDSCommand] (http--0.0.0.0-8080-4)
[2310d22d] START, SetVmTicketVDSCommand(HostName = toji, HostId =
4afae575-0864-4583-93a7-e67d4e4de4ba, vmId=2ba1a9eb-5843-466a-a5e5-530a9c06447b,
ticket=3eaYsvnA+JSb, validTime=120,m userName=admin,
userId=fdfc627c-d875-11e0-90f0-83df133b58cc), log id: 13bb8a5
2014-11-13 13:06:16,544 INFO
[org.ovirt.engine.core.vdsbroker.vdsbroker.SetVmTicketVDSCommand] (http--0.0.0.0-8080-4)
[2310d22d] FINISH, SetVmTicketVDSCommand, log id: 13bb8a5
2014-11-13 13:06:16,587 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(http--0.0.0.0-8080-4) [2310d22d] Correlation ID: 2310d22d, Call Stack: null, Custom Event
ID: -1, Message: user admin initiated console session for VM NS_C001
2014-11-13 13:06:19,501 INFO [org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo]
(DefaultQuartzScheduler_Worker-40) [] VM NS_C001 2ba1a9eb-5843-466a-a5e5-530a9c06447b
moved from PoweringUp --> Up
2014-11-13 13:06:19,595 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(DefaultQuartzScheduler_Worker-40) [] Correlation ID: 668a01e3, Job ID:
dcdb5701-e484-4482-a3a6-0672a2dab68f, Call Stack: null, Custom Event ID: -1, Message: VM
NS_C001 started on Host toji
2014-11-13 13:06:22,763 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(DefaultQuartzScheduler_Worker-49) [] Correlation ID: null, Call Stack: null, Custom Event
ID: -1, Message: User admin is connected to VM NS_C001.
2014-11-13 13:08:21,119 INFO
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
(DefaultQuartzScheduler_Worker-29) [] Correlation ID: null, Call Stack: null, Custom Event
ID: -1, Message: User admin got disconnected from VM NS_C001.
2014-11-13 13:08:21,768 INFO [org.ovirt.engine.core.bll.HibernateVmCommand]
(http--0.0.0.0-8080-4) [1b325763] Lock Acquired to object 'EngineLock [exclusiveLocks=
key: 2ba1a9eb-5843-466a-a5e5-530a9c06447b value: VM
--
To view, visit
http://gerrit.ovirt.org/35105
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No