Change in vdsm[ovirt-3.4]: hsm: Fix missing MAX_DOMAINS constant

[Nir Soffer]

Hello Yaniv Bronhaim, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/24264

to review the following change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

hsm: Fix missing MAX_DOMAINS constant

Commit ab6014b394 moved MAX_DOMAINS from sp to spbackends without
updating all users, breaking creation of a pool on block storage using
old storage domain format. This patch fix the error by importing the
name from its new module.

Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11
Bug-Url: https://bugzilla.redhat.com/1059108
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/24242
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/24264/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 53c9dd0..5efa4ec 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -40,7 +40,7 @@

from vdsm.config import config
 import sp
-from spbackends import MAX_POOL_DESCRIPTION_SIZE
+from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
 from spbackends import StoragePoolDiskBackend
 from spbackends import StoragePoolMemoryBackend
 import domainMonitor
@@ -948,7 +948,7 @@
         msdVersion = msd.getVersion()
         if (msdType in sd.BLOCK_DOMAIN_TYPES and
                 msdVersion in blockSD.VERS_METADATA_LV and
-                len(domList) > sp.MAX_DOMAINS):
+                len(domList) > MAX_DOMAINS):
             raise se.TooManyDomainsInStoragePoolError()

for sdUUID in domList:

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

Patch Set 1: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/136/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/75/ : FAILURE

Yaniv Bronhaim has posted comments on this change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

Patch Set 1: Code-Review+2

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

Patch Set 1: Code-Review+1

Yaniv Bronhaim has posted comments on this change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

Patch Set 1:

verification is what required here now

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

Patch Set 1: Verified+1

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................

hsm: Fix missing MAX_DOMAINS constant

Commit ab6014b394 moved MAX_DOMAINS from sp to spbackends without
updating all users, breaking creation of a pool on block storage using
old storage domain format. This patch fix the error by importing the
name from its new module.

Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11
Bug-Url: https://bugzilla.redhat.com/1059108
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/24242
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: http://gerrit.ovirt.org/24264
Reviewed-by: Allon Mureinik 
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve