5:17 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
BZ#747917 Don't get information about mountpoints
The regular os.walk() function tries to identify the files present in
the given path. Avoiding to descend into the mountpoint is not enough
to prevent vdsm from getting stuck if a NFS mount is unreachable, we
should also prevent any other operation, eg: os.path.isdir().
Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
---
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
2 files changed, 66 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/202/1
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11:38 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
just a minor comment on docstring
....................................................
File vdsm/storage/misc.py
Line 1303: a symlink is on an unreachable mount.
that's no exact, since "blacklist" is not enforced by the function to have
the mountpoints.
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:09 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1324: if path in blacklist:
I will use abspath because it both makes sure it's an absolute path and normalize it.
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:29 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
BZ#747917 Don't get information about mountpoints
The regular os.walk() function tries to identify the files present in
the given path. Avoiding to descend into the mountpoint is not enough
to prevent vdsm from getting stuck if a NFS mount is unreachable, we
should also prevent any other operation, eg: os.path.isdir().
Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
---
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
2 files changed, 73 insertions(+), 7 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:29 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 3: Verified
Verified by Federico with next patch
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:26 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:27 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:57 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1324: if path in blacklist:
I see, just normpath on both ends
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:47 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1324: if path in blacklist:
No, the blacklist paths are (mounted) directories that we don't want to touch at all.
They are currently taken from fileUtils.getMounts() (see hsm.py) and they don't
contain any wildcard.
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:32 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1324: if path in blacklist:
I think this was supposed to be fnmatch
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:42 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#747917 Don't get information about mountpoints
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a9e54586daa766e420fa8571b19a0b744b602d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4506
days inactive
4547
days old
vdsm-patches@lists.fedorahosted.org
10 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Federico Simoncelli -
smizrahi＠redhat.com