Change in vdsm[master]: [WIP] Use a shared resource for images

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] Use a shared resource for images
......................................................................

[WIP] Use a shared resource for images

Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
---
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/sp.py
4 files changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/429/1
--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Use a shared resource for images

[Federico Simoncelli]

Federico Simoncelli has abandoned this change.

Change subject: Use a shared resource for images
......................................................................


Patch Set 3: Abandoned

Using the resource manager on the HSM is broken.

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Use a shared resource for images

Eduardo has posted comments on this change.

Change subject: Use a shared resource for images
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

The actual semantics (before the patch) is buggy and dangerous.
Sorry.

IMHO:
Since the image can't be changed on the HSM  and the local scope Image lock, tacking
this lock on HSM is irrelevant.
The rw volume permission should be changed only when adding/removing a leaf of a volume,
and only on SPM.
When running a VM all the chain of volumes should be activated during prepare. Only this
is required and it is a local (host) operation.
The scope of the rw permission is the cluster and should be changed on the SPM only and is
not related to running VM's as said before.

....................................................
File vdsm/storage/resourceFactories.py
Line 64:         lvm.setrwLV(self._vg, self._lv, True)
This code should not be called for an HSM.
If the lock can be shared because this is not the SPM, then this is a cluster violation.

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Use a shared resource for images

Saggi Mizrahi has posted comments on this change.

Change subject: Use a shared resource for images
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Use a shared resource for images
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: [WIP] Use a shared resource for images
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: [WIP] Use a shared resource for images
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Sorry, why is this change required?

....................................................
File vdsm/storage/resourceFactories.py
Line 64:         lvm.setrwLV(self._vg, self._lv, True)
This was used before for downgrade, now the LV will be writable.

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Use a shared resource for images
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Sorry, but I don't understand why you need all locks as shared

--
To view, visit http://gerrit.ovirt.org/429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8126a7ef9758b3625f4957997ffbe4154e93cc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;