2:59 p.m.
Adam Litke has uploaded a new change for review.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Signed-off-by: Adam Litke <alitke(a)redhat.com>
---
M tests/storage_sdm_copy_data_test.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/65149/1
diff --git a/tests/storage_sdm_copy_data_test.py b/tests/storage_sdm_copy_data_test.py
index 948d170..6b116d5 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -275,7 +275,8 @@
job_id = make_uuid()
job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
t = start_thread(job.run)
- fake_convert.ready_event.wait()
+ if not fake_convert.ready_event.wait(1):
+ raise RuntimeError("Timeout waiting for thread")
job.abort()
t.join(1)
if t.isAlive():
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
3 p.m.
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:01 p.m.
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:02 p.m.
Adam Litke has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:54 p.m.
Nir Soffer has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:55 p.m.
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/65149
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/storage_sdm_copy_data_test.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, approved
Adam Litke: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
3:55 p.m.
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2811
days inactive
2811
days old
vdsm-patches@lists.fedorahosted.org
6 comments
3 participants
participants (3)
-
alitke＠redhat.com -
automation＠ovirt.org -
Nir Soffer