Change in vdsm[master]: Remove the unused nocache option

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Remove the unused nocache option
......................................................................

Remove the unused nocache option

The nocache option to get and set the volume metadata is never used.

Signed-off-by: Federico Simoncelli 
Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 10 insertions(+), 22 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/3747/1
--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 658:             self.__putMetadata(metaarr, metaid)
same comment as in fileVolume.

....................................................
File vdsm/storage/fileVolume.py
Line 398:             self.__putMetadata(metaarr, vol_path)
in former code when used default (nocache=False) in this case we performed 
self.putMetaCache(metaarr).

If you decided to get rid from metaCache it's OK but if not, you just changed behaviour.
Why?

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 398:             self.__putMetadata(metaarr, vol_path)
No matter what the metacache was never used in getMetadata (so why even bother setting it every time?). What I actually forgot to do is to remove all the other self._metadata related methods.

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 17: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 17: Looks good to me, approved

(3 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 685:                     return out
looks like this should be 'break' and not 'return' ?

Line 695:     def setMetadata(self, metaarr, metaid=None):
looks like metaid is never used either?

....................................................
File vdsm/storage/fileVolume.py
Line 382:                     return out
looks like this should be 'break' and not 'return'

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 17: (2 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 685:                     return out
This method needs to be fixed in multiple places, for example also the find/split calls.
I'll add these fixes to another patch to leave this one just to deal with the nocache option.

Line 695:     def setMetadata(self, metaarr, metaid=None):
I'll address this in the new patch too.

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 18: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 19: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Saggi Mizrahi has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 19: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Eduardo has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 19: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 19: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 19: Verified

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 21: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Ayal Baron has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 21: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................

Patch Set 21: Verified

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove the unused nocache option
......................................................................

Remove the unused nocache option

The nocache option to get and set the volume metadata is never used.

Signed-off-by: Federico Simoncelli 
Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 8 insertions(+), 32 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Federico Simoncelli: Verified
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg:

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi