Change in vdsm[master]: spec: enable gluster since fedora 19 and el6

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

spec: enable gluster since fedora 19 and el6

Gluster recently built glusterfs-3.4 alpha2 for f19.

In this patch:
- enable gluster since fedora 19 and el6
- optimize the with_systemd definition to be consistent with the
  gluster one

Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Signed-off-by: Federico Simoncelli 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 6 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/13791/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7a0e638..02150cf 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -17,15 +17,11 @@
 %global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
 %endif

-# Gluster
+%if 0%{?fedora} >= 19 || 0%{?rhel} >= 6
 %global with_gluster 1
-
-# Systemd macro
-%if 0%{?fedora} >= 15
-%global with_systemd 1
 %endif

-%if 0%{?rhel} >= 7
+%if 0%{?fedora} >= 15 || 0%{?rhel} >= 7
 %global with_systemd 1
 %endif

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1900/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1951/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1900/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1951/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1902/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1953/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1902/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1953/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: enable gluster since fedora 19 and el6
......................................................................

Patch Set 2: I would prefer that you didn't submit this

actually, we should let people outside koji build vdsm-gluster.

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1968/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1917/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1968/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1917/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

Patch Set 3: Verified

Verified: the gluster package is always built upstream (fedora_koji_build == 0), or in fedora only for >= f19.

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: spec: enable gluster upstream and on fedora 19

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: enable gluster upstream and on fedora 19
......................................................................

spec: enable gluster upstream and on fedora 19

The gluster package should be always enabled upstream or since fedora 19
in koji builds.

Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Signed-off-by: Federico Simoncelli 
---
M vdsm.spec.in
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68436bf10cecdaea8b3ce6c95797aac4895ec482
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: oVirt Jenkins CI Server