Change in vdsm[master]: NetReload: netmodels for addNetwork

Giuseppe Vallarelli has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 50: 
Line 51: def objectivizeNetwork(net, bridged=None, vlan=None, bonding=None,
Line 52:                        bondingOptions=None, nics=None, mtu=None, ipaddr=None,
Line 53:                        netmask=None, gateway=None, bootproto=None,
Line 54:                        _netinfo=None, configurator=None, **opts):
What about having Ifcfg() as default parameter to configurator, same for netinfo.NetInfo()
? So you can remove these 2 ifs.
Line 55:     if configurator is None:
Line 56:         configurator = Ifcfg()
Line 57:     if _netinfo is None:
Line 58:         _netinfo = netinfo.NetInfo()


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server