Change in vdsm[master]: Make exprting more pythonic

Saggi Mizrahi has uploaded a new change for review.

Change subject: Make exprting more pythonic
......................................................................

Make exprting more pythonic

This seperated the dispatcher from hsm and allows us to add propertoes
to all public function with ease

Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
---
M vdsm/clientIF.py
M vdsm/storage/dispatcher.py
M vdsm/storage/hsm.py
M vdsm/vdsm
4 files changed, 185 insertions(+), 184 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/208/1
--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make exporting more pythonic
......................................................................


Make exporting more pythonic

This seperated the dispatcher from hsm and allows us to add propertoes
to all public function with ease

Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
---
M vdsm/clientIF.py
M vdsm/storage/dispatcher.py
M vdsm/storage/hsm.py
M vdsm/vdsm
4 files changed, 180 insertions(+), 180 deletions(-)

Approvals:
  Saggi Mizrahi: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 14: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1009:     def public_getVmsList(self, spUUID, sdUUID=None, options = None):
Oops, why public_ ?

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ilvovsky(a)gmail.com

Change in vdsm[master]: Make exporting more pythonic

Saggi Mizrahi has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 14: Verified

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 191:         em.ResourceManager.getInstance().registerNamespace(STORAGE,
rm.SimpleResourceFactory())
do you check my awareness level with this "em"?

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 87:     declogger = kwargs.get("logger", logged())
pardon my ignorance, by why "declogger"? what's "dec"

Line 191:         em.ResourceManager.getInstance().registerNamespace(STORAGE,
rm.SimpleResourceFactory())
em? probably meant rm

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 65: import resourceManager
You already have it:  
import resourceManager as rm

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 64: import resourceManager
This was already imported as rm.

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Make exporting more pythonic

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ilvovsky(a)gmail.com

Change in vdsm[master]: Make exporting more pythonic

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ilvovsky(a)gmail.com

Change in vdsm[master]: Make exporting more pythonic

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exporting more pythonic
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make exprting more pythonic
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 355:     def public_spmStart(self, spUUID, prevID, prevLVER, recoveryMode,
scsiFencing,
public_spmStart  -> spmStart

--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;