Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ......................................................................
netlink: fix pep8 for 1.4.5 (was fine for 1.4.6)
Change-Id: Ie0d16267e0ed7788c5a7190e1e7e2793fdd0ba1f Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M lib/vdsm/netlink.py 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/24602/1
diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py index a22d6a4..eeb8e95 100644 --- a/lib/vdsm/netlink.py +++ b/lib/vdsm/netlink.py @@ -154,8 +154,7 @@ 'prefixlen': _rtnl_addr_get_prefixlen(addr), 'scope': _addr_scope(addr), 'flags': _rtnl_addr_get_flags(addr), - 'address': _addr_local(addr), - } + 'address': _addr_local(addr)}
def _link_info(cache, link):
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ......................................................................
Patch Set 1: Code-Review+2
Too bad...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ......................................................................
netlink: fix pep8 for 1.4.5 (was fine for 1.4.6)
Change-Id: Ie0d16267e0ed7788c5a7190e1e7e2793fdd0ba1f Signed-off-by: Antoni S. Puimedon asegurap@redhat.com Reviewed-on: http://gerrit.ovirt.org/24602 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/netlink.py 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7290/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6388/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7172/ : SUCCESS
vdsm-patches@lists.fedorahosted.org