Dan Kenigsberg has uploaded a new change for review.
Change subject: doh! fix the former commit ......................................................................
doh! fix the former commit
I've decorated the class instead of the test method :-(
Change-Id: I5d99275ee7cf04e8464f4718c765bca901178e8c Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/miscTests.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/8984/1
diff --git a/tests/miscTests.py b/tests/miscTests.py index 93a20cd..eeb14d4 100644 --- a/tests/miscTests.py +++ b/tests/miscTests.py @@ -70,9 +70,9 @@ proc.wait()
-@brokentest('Test sometimes fail, when misc.getCmdArgs() returns ' - 'the empty tuple right after process creation') class GetCmdArgsTests(TestCaseBase): + @brokentest('Test sometimes fail, when misc.getCmdArgs() returns ' + 'the empty tuple right after process creation') def test(self): args = ("sleep", "4") sproc = misc.execCmd(args, sync=False, sudo=False)
-- To view, visit http://gerrit.ovirt.org/8984 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5d99275ee7cf04e8464f4718c765bca901178e8c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: doh! fix the former commit ......................................................................
Patch Set 1: Verified; Looks good to me, approved
not properly tested...
-- To view, visit http://gerrit.ovirt.org/8984 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5d99275ee7cf04e8464f4718c765bca901178e8c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: doh! fix the former commit ......................................................................
doh! fix the former commit
I've decorated the class instead of the test method :-(
Change-Id: I5d99275ee7cf04e8464f4718c765bca901178e8c Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/miscTests.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/8984 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I5d99275ee7cf04e8464f4718c765bca901178e8c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
vdsm-patches@lists.fedorahosted.org