Liron Aravot has posted comments on this change.
Change subject: core: moving InquireNotSupportedError to storage_exception.py
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/45763/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 599: # This happens when we cannot read the MD LV
Line 600: self.log.error("Can't read LV based metadata",
exc_info=True)
Line 601: raise se.StorageDomainMasterError("Can't read LV based
metadata")
Line 602: except se.InquireNotSupportedError:
Line 603: self.log.error("Inquire spm status isn't supported by the
used cluster lock", exc_info=True)
- line too long
Done
Line 604: raise
Line 605: except se.StorageException as e:
Line 606: self.log.error("MD read error: %s", str(e),
exc_info=True)
Line 607: raise se.StorageDomainMasterError("MD read error")
https://gerrit.ovirt.org/#/c/45763/1/vdsm/storage/storage_exception.py
File vdsm/storage/storage_exception.py:
Line 1618: message = "Could not initialize cluster lock"
Line 1619:
Line 1620: class InquireNotSupportedError(StorageException):
Line 1621: code = 702
Line 1622: message = "Cluster lock inquire isnt supported"
Cluster lock does not support inquire?
we inquire the cluster
lock, not inquiring using the cluster lock..so i'd prefer the current message.
Line 1623:
Line 1624: #################################################
Line 1625: # Meta data related Exceptions
Line 1626: #################################################
--
To view, visit
https://gerrit.ovirt.org/45763
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8201794dc96ee24dc9c0da5b7c3d71ab0b75e9f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes