Change in vdsm[master]: [wip] jsonrpc: Vdsm changes

Adam Litke has posted comments on this change.

Change subject: [wip] jsonrpc: Vdsm changes
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2932
Line 2933
Line 2934
Line 2935
Line 2936
How would you describe that this could return either ['UUID'] or
['VmDescription'] ?


Line 2951: #
Line 2952: # @vmList:      #optional Filter the results by a list of UUIDs
Line 2953: #
Line 2954: # @fullStatus:  #optional Flag which detremines whether to return full status
Line 2955: #
This is a bad idea.  One major cleanup that this schema has imposed is that a function has
a stable return type.  It is not good to have a parameter that can change the return value
from a list of UUIDs to a list of VmDescriptions.
Line 2956: # Returns:
Line 2957: # A list of VM UUIDs
Line 2958: #
Line 2959: # Since: 4.10.0


-- 
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes