Change in vdsm[master]: BZ#812793 - Fix addNetwork to be able attach network to inte...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: BZ#812793 - Fix addNetwork to be able attach network to interface
......................................................................

BZ#812793 - Fix addNetwork to be able attach network to interface

Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/configNetwork.py
M vdsm/netinfo.py
2 files changed, 16 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/4107/1
--
To view, visit http://gerrit.ovirt.org/4107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#812793 - Fix addNetwork to be able attach network to interface
......................................................................


BZ#812793 - Fix addNetwork to be able attach network to interface

Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/configNetwork.py
M vdsm/netinfo.py
2 files changed, 13 insertions(+), 10 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#812793 - Fix addNetwork to be able attach network to interface
......................................................................


Patch Set 2: Verified; Looks good to me, approved

(1 inline comment)

verified by Igor

....................................................
File vdsm/netinfo.py
Line 326:         for bridge, netdict in self.networks.iteritems():
TODO: this function must work also for bridgeless networks!

--
To view, visit http://gerrit.ovirt.org/4107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#812793 - Fix addNetwork to be able attach network to interface
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/4107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c253048fb4d10389228b91aec06253f737be22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;