10:54 a.m.
Assaf Muller has uploaded a new change for review.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Per device custom properties for before/after vm destroy.
Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Signed-off-by: Assaf Muller <amuller(a)redhat.com>
---
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
5 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/13411/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 32eb97d..724a113 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -794,6 +794,8 @@
%{_libexecdir}/%{vdsm_name}/spmstop.sh
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_device_create
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_device_create
+%dir %{_libexecdir}/%{vdsm_name}/hooks/before_device_destroy
+%dir %{_libexecdir}/%{vdsm_name}/hooks/after_device_destroy
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_vm_start
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_vm_cont
diff --git a/vdsm/hooks.py b/vdsm/hooks.py
index a2cb932..c66bfef 100644
--- a/vdsm/hooks.py
+++ b/vdsm/hooks.py
@@ -101,6 +101,16 @@
params=customProperties)
+def before_device_destroy(devicexml, vmconf={}, customProperties={}):
+ return _runHooksDir(devicexml, 'before_device_destroy', vmconf=vmconf,
+ params=customProperties)
+
+
+def after_device_destroy(devicexml, vmconf={}, customProperties={}):
+ return _runHooksDir(devicexml, 'after_device_destroy', vmconf=vmconf,
+ params=customProperties)
+
+
def before_vm_start(domxml, vmconf={}):
return _runHooksDir(domxml, 'before_vm_start', vmconf=vmconf)
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 4c41c6b..3f682dc 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -2599,6 +2599,11 @@
hooks.after_vm_destroy(self._lastXMLDesc, self.conf)
+ for devType in self._devices:
+ for dev in self._devices[devType]:
+ hooks.after_device_destroy(dev._deviceXML, self.conf,
+ getattr(dev, 'custom', {}))
+
self._released = True
return {'status': doneCode}
@@ -2618,6 +2623,11 @@
def destroy(self):
self.log.debug('destroy Called')
+ for devType in self._devices:
+ for dev in self._devices[devType]:
+ hooks.before_device_destroy(dev._deviceXML, self.conf,
+ getattr(dev, 'custom', {}))
+
hooks.before_vm_destroy(self._lastXMLDesc, self.conf)
self.destroyed = True
diff --git a/vdsm/vdsmd.8.in b/vdsm/vdsmd.8.in
index 50da8cf..1803b58 100644
--- a/vdsm/vdsmd.8.in
+++ b/vdsm/vdsmd.8.in
@@ -48,6 +48,7 @@
before_vm_destroy, after_vm_destroy,
before_vm_set_ticket, after_vm_set_ticket,
before_device_create, after_device_create,
+ before_device_destroy, after_device_destroy,
before_nic_hotplug, after_nic_hotplug, after_nic_hotplug_fail,
before_nic_hotunplug, after_nic_hotunplug, after_nic_unhotplug_fail,
before_disk_hotplug, after_disk_hotplug,
@@ -89,7 +90,8 @@
before_nic_hotunplug, after_nic_hotunplug, after_nic_unhotplug_fail,
before_disk_hotplug, after_disk_hotplug,
before_disk_hotunplug, after_disk_hotunplug,
- before_device_create, after_device_create.
+ before_device_create, after_device_create,
+ before_device_destroy, after_device_destroy.
Are all augmented by custom properties specific to those devices, sent by the caller of
the hook. For example if before_nic_hotplug is called with custom: {qos: '0.5',
color: 'red'} then qos and color will be directly available as environment
variables when before_nic_hotplug is called.
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 3f890f6..12bea50 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -61,6 +61,8 @@
VDSMHOOKS = \
before_device_create \
after_device_create \
+ before_device_destroy \
+ after_device_destroy \
before_vm_start \
after_vm_start \
before_vm_cont \
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
7:44 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Per device custom properties for before/after vm destroy.
Patch Set 2:
Run before/after device destroy hooks only on devices that
have custom properties. after_device_create,
before_device_destroy and after_device_destroy hook calls
now share code (Removed code duplication).
Patch Set 3+:
Code styling and prettifying.
Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Signed-off-by: Assaf Muller <amuller(a)redhat.com>
---
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
5 files changed, 47 insertions(+), 24 deletions(-)
Approvals:
Assaf Muller: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:44 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:48 a.m.
Assaf Muller has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 5: Verified
Verified with fake hooks called at the new hook points, with injected custom properties.
Only devices that had custom properties were called.
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:47 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1801/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1852/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:43 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1801/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:43 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1852/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:39 a.m.
Assaf Muller has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4: (1 inline comment)
Answer to in-code comments.
....................................................
File vdsm/libvirtvm.py
Line 1317:
Line 1318: for devType in self._devices:
Line 1319: for dev in self._devices[devType]:
Line 1320: if devType == vm.NIC_DEVICES:
Line 1321: dev.custom = {'qos': 3}
To quote the Firefox team:
"Well, this is embarrassing..."
Line 1322:
Line 1323: for dev in self._customDevices():
Line 1324: deviceXML = dev.getXML().toxml(encoding='utf-8')
Line 1325: deviceXML = hooks.before_device_create(
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:28 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1294: leaseElem.appendChildWithArgs('target', path=leasePath,
Line 1295: offset=str(leaseOffset))
Line 1296: return leaseElem
Line 1297:
Line 1298: def _customDevices(self):
oh, so here's the generator!
Line 1299: """
Line 1300: Get all devices that have custom properties
Line 1301: """
Line 1302:
Line 1317:
Line 1318: for devType in self._devices:
Line 1319: for dev in self._devices[devType]:
Line 1320: if devType == vm.NIC_DEVICES:
Line 1321: dev.custom = {'qos': 3}
this looks like a private test, sneaking upstream.
Line 1322:
Line 1323: for dev in self._customDevices():
Line 1324: deviceXML = dev.getXML().toxml(encoding='utf-8')
Line 1325: deviceXML = hooks.before_device_create(
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:53 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1781/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1832/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:51 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1832/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:51 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1781/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:02 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1777/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1828/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1777/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1828/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:44 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1776/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1827/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1827/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1776/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:19 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:56 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1746/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1797/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1746/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Per device custom properties for before/after vm destroy.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1797/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18b838dc51ea6bde31ef1a4bf0d0d372d95cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4048
days inactive
4055
days old
vdsm-patches@lists.fedorahosted.org
21 comments
3 participants
participants (3)
-
amuller＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO