Ondřej Svoboda has uploaded a new change for review.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
ipv6 hook: support ipv6addrs
Change-Id: I722d0007840060cdccdb12e4fba2a2066f33c62f Signed-off-by: Ondřej Svoboda osvoboda@redhat.com --- M vdsm_hooks/ipv6/README M vdsm_hooks/ipv6/ipv6.py 2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/39359/1
diff --git a/vdsm_hooks/ipv6/README b/vdsm_hooks/ipv6/README index 05bd990..a96e2c2 100644 --- a/vdsm_hooks/ipv6/README +++ b/vdsm_hooks/ipv6/README @@ -5,13 +5,18 @@ Requirements: * oVirt-3.5 (started supporting custom properties)
+New in version 4.18: (?) +-------------------- +Multiple IPv6 addresses are now accepted, see Usage. Please use 'ipv6addrs' +property instead of 'ipv6addr' which is deprecated. + Preparation on a host: ---------------------- yum install vdsm-hook-ipv6
Preparation on the engine side: ------------------------------- -PROPERTIES='ipv6addr=.*;ipv6gateway=.*;ipv6autoconf=.*;dhcpv6=.*' +PROPERTIES='ipv6addrs=.*;ipv6gateway=.*;ipv6autoconf=.*;dhcpv6=.*' engine-config -s "UserDefinedNetworkCustomProperties=$PROPERTIES" --cver='3.5'
Don't forget to include the names of other custom network properties you may @@ -20,9 +25,10 @@ Usage: ------ In the oVirt UI open the 'Setup Host Networks' dialog. Proceed to editing -a desired logical network's properties. Among them you will find 'ipv6addr' -and 'ipv6gateway', which accept custom IPv6 addresses, plus 'ipv6autoconf' -and 'dhcpv6', which accept '0', '1' or 'false', 'true'. +a desired logical network's properties. Among them you will find 'ipv6addrs' +(which accepts a space-separated list of IPv6 addresses), 'ipv6gateway' +(a single address), plus 'ipv6autoconf' and 'dhcpv6', which accept '0', '1' or +'false', 'true'.
You may be warned that the network is in use when confirming the 'Setup Host Networks' dialog. Make sure to stop any VMs that are using the network. diff --git a/vdsm_hooks/ipv6/ipv6.py b/vdsm_hooks/ipv6/ipv6.py index 6c00475..9385fab 100644 --- a/vdsm_hooks/ipv6/ipv6.py +++ b/vdsm_hooks/ipv6/ipv6.py @@ -34,7 +34,8 @@
def _process_network(attrs): - for property_name in ('ipv6addr', 'ipv6gateway', 'ipv6autoconf', 'dhcpv6'): + for property_name in ('ipv6addrs', 'ipv6addr', 'ipv6gateway', + 'ipv6autoconf', 'dhcpv6'): value = attrs['custom'].get(property_name) if value is not None: attrs[property_name] = value
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 1:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17330/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 1:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17504/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17330/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17504/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39359/1/vdsm_hooks/ipv6/ipv6.py File vdsm_hooks/ipv6/ipv6.py:
Line 33: hooking.write_json(setup_nets_config) Line 34: Line 35: Line 36: def _process_network(attrs): Line 37: for property_name in ('ipv6addrs', 'ipv6addr', 'ipv6gateway', how does it go? don't you need an ipv6gateway per ipv6 address? Line 38: 'ipv6autoconf', 'dhcpv6'): Line 39: value = attrs['custom'].get(property_name) Line 40: if value is not None: Line 41: attrs[property_name] = value
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 2:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17555/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 2:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17729/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17555/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17729/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Petr Horáček has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/39359/3/vdsm_hooks/ipv6/README File vdsm_hooks/ipv6/README:
Line 19: PROPERTIES='ipv6addrs=.*;ipv6gateway=.*;ipv6autoconf=.*;dhcpv6=.*' Line 20: engine-config -s "UserDefinedNetworkCustomProperties=$PROPERTIES" --cver='3.5' Line 21: Line 22: Don't forget to include the names of other custom network properties you may Line 23: want to use, such as 'ethtool_opts'. please, mention that we have to restart engine to complete the setup Line 24: Line 25: Usage: Line 26: ------ Line 27: In the oVirt UI open the 'Setup Host Networks' dialog. Proceed to editing
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: ipv6 hook: support ipv6addrs ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Patch Set 1:
(1 comment)
One late answer from April.
https://gerrit.ovirt.org/#/c/39359/1/vdsm_hooks/ipv6/ipv6.py File vdsm_hooks/ipv6/ipv6.py:
Line 33: hooking.write_json(setup_nets_config) Line 34: Line 35: Line 36: def _process_network(attrs): Line 37: for property_name in ('ipv6addrs', 'ipv6addr', 'ipv6gateway',
how does it go? don't you need an ipv6gateway per ipv6 address?
Other than IPv6 source routing? It may come as an extension but let's go step by step. If I did not understand please specify the need for multiple (seemingly undistinguishable) gateways. Line 38: 'ipv6autoconf', 'dhcpv6'): Line 39: value = attrs['custom'].get(property_name) Line 40: if value is not None: Line 41: attrs[property_name] = value
automation@ovirt.org has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Jenkins CI RO has abandoned this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org