Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Clean up flowID logging ......................................................................
Clean up flowID logging
This change should prevent empty IDs being logged.
Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae --- M vdsm/BindingXMLRPC.py 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/1863/1 -- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
Dan Kenigsberg has posted comments on this change.
Change subject: Clean up flowID logging ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
thanks, would you add yourself to AUTHORS ?
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Clean up flowID logging ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Clean up flowID logging ......................................................................
Patch Set 1:
Would you prefer if I added myself to the AUTHORS file in the same commit or separate?
I'll also reword the commit message to 'Prevent logging empty flow IDs'
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Clean up flowID logging ......................................................................
Patch Set 1: Verified
During my tests I never saw empty IDs being logged but your patch looks better then the current code. ACK from my side. Thanks!
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
Dan Kenigsberg has posted comments on this change.
Change subject: Clean up flowID logging ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Clean up flowID logging ......................................................................
Clean up flowID logging
This change should prevent empty IDs being logged.
Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae --- M vdsm/BindingXMLRPC.py 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1863 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
vdsm-patches@lists.fedorahosted.org