[NEW PATCH] BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate (via gerrit-bot)
7:35 a.m.
New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/865
commit 77cbfcc06bc83280d21478a16c4a531de8491e2d
Author: Saggi Mizrahi <smizrahi(a)redhat.com>
Date: Tue Aug 30 11:14:25 2011 +0300
BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index b16df9b..79fc3cc 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -855,7 +855,16 @@ class AsyncProc(object):
# trun on only if data is waiting to be pushed
self._poller.modify(self._fdin, select.EPOLLOUT)
- for fd, event in self._poller.poll(1):
+ pollres = None
+ while pollres is None:
+ try:
+ pollres = self._poller.poll(1)
+ except OSError as e:
+ if e.errno in (errno.EINTR, errno.EAGAIN):
+ continue
+ raise
+
+ for fd, event in pollres:
stream = self._fdMap[fd]
if event & select.EPOLLOUT and self._stdin.len > 0:
buff = self._stdin.read(BUFFSIZE)
4:08 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
---
M vdsm/storage/misc.py
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
Eduardo Warszawski: Looks good to me, but someone else must approve
Haim Ateya: Verified
Ayal Baron: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:08 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:05 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Igor Lvovsky has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:39 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Eduardo Warszawski has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 863: if e.errno in (errno.EINTR, errno.EAGAIN):
Can we log here?
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:02 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 865: raise
No, I meant none. If poller returns an empty list everything works as designed. EINTR is
not an issue. If EAGAIN is happening repeatedly VDSM is going to crash because there is no
memory.
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:01 p.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Eduardo Warszawski has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 2: Do not submit
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 865: raise
poll call timeout is indicated by an empty list that is not None.
Do you mean [] instead?
Loop on timeout result leads to a potential infinite loop.
In addition there is no escape from repeated EINTR or EAGAIN conditions.
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:48 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Haim Ateya has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 2: Verified
patch #2 fix both BZ#732245,BZ#732269.
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:45 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Igor Lvovsky has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:55 a.m.
New subject: Change in vdsm[master]: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc....
Igor Lvovsky has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/865
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4617
days inactive
4622
days old
vdsm-patches@lists.fedorahosted.org
9 comments
5 participants
participants (5)
-
Dan Kenigsberg -
ewarszaw＠redhat.com -
Haim Ateya -
Igor Lvovsky -
smizrahi＠redhat.com