From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Don't patch *VolumePath in test_change_cd_failures
......................................................................
virt: Don't patch *VolumePath in test_change_cd_failures
There is no need to monkey patch those methods to make the test pass.
Actually patching prepareVolumePath leads to an XML error that is raised and
silently swallowed. In the result, we test for a failure, but a wrong failure:
Not the libvirt one, but the XML formatting failure.
We additionally need this fix for a followup patch where XML formatting is
taken out of the corresponding try...except block.
Backport-To: 4.1
Bug-Url:
https://bugzilla.redhat.com/1428514
Change-Id: I303c1f84653b1a76008405904a22441873ddc224
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M tests/vm_test.py
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit
https://gerrit.ovirt.org/75147
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I303c1f84653b1a76008405904a22441873ddc224
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>