Federico Simoncelli has uploaded a new change for review.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Automatically detect qemu-kvm path in vdsm-faqemu
Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd --- M .gitignore M configure.ac M vdsm_hooks/faqemu/Makefile.am A vdsm_hooks/faqemu/vdsm-faqemu D vdsm_hooks/faqemu/vdsm-faqemu.in 5 files changed, 24 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/2159/1 -- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Patch Set 1:
why not trust autoconf? (and BuildRequires)
-- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Patch Set 2: Looks good to me, approved
ok ok, build-requiring vdsm-hook-faqemu just for finding its path is ugly.. let's do it in runtime as you suggest.
-- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Adam Litke has posted comments on this change.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Automatically detect qemu-kvm path in vdsm-faqemu
Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd --- M .gitignore M configure.ac M vdsm_hooks/faqemu/Makefile.am A vdsm_hooks/faqemu/vdsm-faqemu D vdsm_hooks/faqemu/vdsm-faqemu.in 5 files changed, 24 insertions(+), 18 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Automatically detect qemu-kvm path in vdsm-faqemu ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/2159 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3f62f0b3bbe134cbb004fe3357e92e1c6b4585cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org