Federico Simoncelli has posted comments on this change.
Change subject: sdcache: add refresh to connectStoragePool
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 638: self._saveReconnectInformation(hostID, scsiKey, msdUUID, masterVersion)
Line 639: self.id = hostID
Line 640: self.scsiKey = scsiKey
Line 641: # Make sure SDCache doesn't have stale data (it can be in case of
FC)
Line 642: sdCache.invalidateStorage()
Yes it might be useful to have it there too to trigger a rescan.
Line 643: sdCache.refresh()
Line 644: # Rebuild whole Pool
Line 645: self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion)
Line 646: self.__createMailboxMonitor()
Line 639: self.id = hostID
Line 640: self.scsiKey = scsiKey
Line 641: # Make sure SDCache doesn't have stale data (it can be in case of
FC)
Line 642: sdCache.invalidateStorage()
Line 643: sdCache.refresh()
This is not needed in connectStorageServer because you would delete the entire domain
cache when you connect to a new storage server. E.g.: you want to add a new storage =>
you would clean the cache of all the know domains.
I think you're looking forward to unify the methods, and I actually agree, I thought
about it a couple of times. We might try to do so and add a parameter to skip the domain
cache clean up in the few cases we don't want it.
Line 644: # Rebuild whole Pool
Line 645: self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion)
Line 646: self.__createMailboxMonitor()
Line 647:
--
To view, visit
http://gerrit.ovirt.org/9422
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d3adcff7bb0e97be5c797cd720c6353920d9db0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server