6:04 a.m.
Hello Timothy Asir, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/3386
to review the following change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Added getDevicePartedInfo function in supervdsm.
This function accepts device path and returns its information as
dictionary. Sample return value is,
{'model': 'Virtio Block Device',
'sectorSize': 512L,
'type': 'gpt',
'freeSpaceRegions': [(34L, 2047L, 2014L, 1031168L),
(16775168L, 16777182L, 2015L, 1031680L)],
'partitions': [('/dev/vda1', ['bios_grub'], 2048L, 4095L),
('/dev/vda2', ['boot'], 4096L, 16285695L),
('/dev/vda3', [], 16285696L, 16775167L)]}
Change-Id: I6388d6c112abf106471223101be495f20f157c66
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/parted_super.py
M vdsm/supervdsmServer.py
4 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/3386/1
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:56 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Added getDevicePartedInfo function in supervdsm.
This function accepts device path and returns its information as
dictionary. Sample return value is,
{'model': 'Virtio Block Device',
'sectorSize': 512L,
'type': 'gpt',
'freeSpaceRegions': [(34L, 2047L, 2014L, 1031168L),
(16775168L, 16777182L, 2015L, 1031680L)],
'partitions': {'/dev/vda1': (['bios_grub'], 2048L, 4095L),
'/dev/vda2': (['boot'], 4096L, 16285695L),
'/dev/vda3': ([], 16285696L, 16775167L)}}
Change-Id: I6388d6c112abf106471223101be495f20f157c66
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M Makefile.am
M tests/Makefile.am
A tests/parted_utils_tests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/parted_utils.py
M vdsm/supervdsmServer.py
7 files changed, 176 insertions(+), 0 deletions(-)
Approvals:
Timothy Asir: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:56 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 6: Looks good to me, approved
I hope I've given enough time for objections.
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
1:32 a.m.
Timothy Asir has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
5:36 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
7:13 a.m.
Bala.FA has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File tests/parted_utils_tests.py
Line 47: os.close(tempFd)
As per docs, tempfile.NamedTemporaryFile(delete=false) return file like object using
mkstemp(). The returned object has opened fd with mode 'w+b' too. My intention
is to have 'free' tempfile for losetup. So
tempfile.NamedTemporaryFile(delete=false) dpesn't give any value here.
Line 52: self.assertTrue(rc == 0)
I will go with assertEquals() :)
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:07 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 5: No score
Oh, please add parted_utils.py to pep8's whitelist.
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:01 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 5: Verified; Looks good to me, but someone else must approve
(2 inline comments)
but please consider the two comments within.
....................................................
File tests/parted_utils_tests.py
Line 47: os.close(tempFd)
ok, if the docs says so... I still think it is ugly to touch the fd w/o purpose. how about
tempfile.NamedTemporaryFile(delete=false) ?
Line 52: self.assertTrue(rc == 0)
assertEquals() gives even more info on failure. but it's your call.
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4:05 a.m.
Bala.FA has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 4: (7 inline comments)
New patch is on the way with these changes
....................................................
File tests/parted_utils_tests.py
Line 45: os.close(tempFd)
according to python docs, mktemp: Deprecated since version 2.3: Use mkstemp() instead.
Line 49: rc, out, err = utils.execCmd(cmd.split())
Done
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
Done. I will use @ValidateRunningAsRoot
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
This test should run as root. Sorry for the confusion.
Line 69: assert not putils.getDevicePartedInfo('/dev/abcdef')
Done
Line 72: info = putils.getDevicePartedInfo(self.devPath)
Required root privilege (not sudo) to run the test.
Line 95: assert (info['type'] == 'gpt')
Done
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:12 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
Looks good, but I lack a use case for this function,
and a unittest for the new module. Please use the nice new unit tests framework, or it
would rust!
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
2:02 a.m.
Mark Wu has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
8:19 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Don't user _super suffix for module names. It mixes implementation details with
naming.
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:57 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File tests/parted_utils_tests.py
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
heh, you may want to use Saggi's fresh checkSudo:
http://gerrit.ovirt.org/#patch,sidebyside,3596,1,tests/miscTests.py
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:05 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File tests/parted_utils_tests.py
Line 45: os.close(tempFd)
if you do not use tempFd, there is no much point of using the s variant of mktemp...
Line 49: rc, out, err = utils.execCmd(cmd.split())
it is bad practice to split command line on spaces. assume tempFilePath has a space
within. I'd very much prefer that you make cmd a pre-parsed tuple literal.
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
this requires whomever runs the test to have sudo permissions for losetup.
I do not think this is common or safe. We may need to
@ValidateRunningAsRoot (or do you have a better solution?)
Line 69: assert not putils.getDevicePartedInfo('/dev/abcdef')
self.assertFalse() gives a little bit more information on failure.
consider using it and its friends instead of simple "assert".
Line 72: info = putils.getDevicePartedInfo(self.devPath)
I did not research into this, but I'm getting info={} here on my f16 box.
Line 95: assert (info['type'] == 'gpt')
your parenthesis lack consistency
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4:41 a.m.
Bala.FA has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 2:
use-case is gluster only now.
New patch is on the way with unittests.
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4441
days inactive
4455
days old
vdsm-patches@lists.fedorahosted.org
14 comments
5 participants
participants (5)
-
barumuga＠redhat.com -
Dan Kenigsberg -
smizrahi＠redhat.com -
tjeyasin＠redhat.com -
wudxw＠linux.vnet.ibm.com