Change in vdsm[master]: Move libvirt username into config

[Ryan Harper]

Ryan Harper has uploaded a new change for review.

Change subject: Move libvirt username into config
......................................................................

Move libvirt username into config

Removed hardcoded username string from specfile and source
Created a new 'auth' config section in config.py.in
    - define a new variable 'libvirt_user'
Update configure.ac to contain a default value without 'rhev' in the name
Update libvirtconnection.py to use the configuration variable

Change-Id: Ibacef5ab3c1a6320086bf6d5c694ec060a6b7bbe
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com&gt;
---
M configure.ac
M vdsm.spec.in
M vdsm/config.py.in
M vdsm/libvirtconnection.py
4 files changed, 12 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/3291/1
--
To view, visit http://gerrit.ovirt.org/3291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibacef5ab3c1a6320086bf6d5c694ec060a6b7bbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;

Adam Litke has posted comments on this change.

Change subject: Move libvirt username into config
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Just a small suggestion to change the userid to vdsm@ovirt.

....................................................
File configure.ac
Line 64: AC_SUBST([LIBVIRTUSER], ['vdsm@node'])
vdsm@ovirt ?

--
To view, visit http://gerrit.ovirt.org/3291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibacef5ab3c1a6320086bf6d5c694ec060a6b7bbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;

[Ryan Harper]

Ryan Harper has abandoned this change.

Change subject: Move libvirt username into config
......................................................................


Patch Set 1: Abandoned

Too Old

--
To view, visit http://gerrit.ovirt.org/3291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibacef5ab3c1a6320086bf6d5c694ec060a6b7bbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server