Change in vdsm[master]: Remove unused hsm._hsmSchedule()

Eduardo has uploaded a new change for review.

Change subject: Remove unused hsm._hsmSchedule()
......................................................................

Remove unused hsm._hsmSchedule()

Related to: BZ#960952.

Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/storage/hsm.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/16411/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 5a5b4fb..f0faee2 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -396,10 +396,6 @@
         storageRefreshThread.daemon = True
         storageRefreshThread.start()
 
-    def _hsmSchedule(self, name, func, *args):
-        self.taskMng.scheduleJob("hsm", self.tasksDir, vars.task,
-                                 name, func, *args)
-
     def __validateLvmLockingType(self):
         """
         Check lvm locking type.


-- 
To view, visit http://gerrit.ovirt.org/16411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove unused hsm._hsmSchedule()
......................................................................


Remove unused hsm._hsmSchedule()

Related to: BZ#960952.

Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/16411
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Tested-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/storage/hsm.py
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, approved
  Dan Kenigsberg: Verified


-- 
To view, visit http://gerrit.ovirt.org/16411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove unused hsm._hsmSchedule()
......................................................................


Patch Set 1: Verified

Method unused, no need to verify.

-- 
To view, visit http://gerrit.ovirt.org/16411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Remove unused hsm._hsmSchedule()
......................................................................


Patch Set 1: Looks good to me, approved

-- 
To view, visit http://gerrit.ovirt.org/16411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove unused hsm._hsmSchedule()
......................................................................


Patch Set 1: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3064/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3142/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2250/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/16411
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92b9fcd899463157951fb76ab7ac6dfb4b47caf9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server