Change in vdsm[master]: (Schema) Replace IntStr with proper integer types

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

(Schema) Replace IntStr with proper integer types

Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 61 insertions(+), 70 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/6841/1
--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

Patch Set 1:

Hmm, I am conflicted here.  I definitely agree that we need to differentiate between signed and unsigned ints but I am not so sure about supporting all of the explicit sizes.  The acceptable ranges for some of these fields do conform exactly to the set of 32bit numbers but for many of them the range is further restricted.

I wonder if it makes more sense to have only: int and uint where both are 64bits in size.  We need to write field validation anyway so the exact ranges can be encoded in the annotations (comment block) and those ranges can be automatically enforced by an integer range validator function on the server side.

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg

Adam Litke has posted comments on this change.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

Patch Set 2: I would prefer that you didn't submit this

Initial comments not addressed.

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has submitted this change and it was merged.

Change subject: (Schema) Replace IntStr with proper integer types
......................................................................

(Schema) Replace IntStr with proper integer types

Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 58 insertions(+), 67 deletions(-)

Approvals:
  Saggi Mizrahi: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi