Change in vdsm[master]: Move createLibvirtNetwork and removeLibvirtNetwork to the Co...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter

Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Signed-off-by: Igor Lvovsky 
---
M vdsm/clientIF.py
M vdsm/configNetwork.py
M vdsm/netinfo.py
3 files changed, 54 insertions(+), 49 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/6893/1
--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

Livnat Peer has posted comments on this change.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netinfo.py
Line 36: NET_CONF_BACK_DIR = constants.P_VDSM_LIB + 'netconfback/'
I think that the name of the folder should not be specific to libvirt.
We'll use it to backup logical networks info were we don't have config files, this info is used to restore the networks in libvirt.
I would call it - 'logicalnetworks/'

--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 191:     def removeLibvirtNetwork(cls, network, log=True):
the whole point of moving this into the class was to make it possible to store stuff in "self". I do not see why we need an intermediate stage where this is a @classmethod.

Line 260:     def writeConfFile(self, fileName, configuration):
you know me - I don't think that moving this function around has any merit, certainly not within this patch.

--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Patch Set 3: Looks good to me, approved

still good.

--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
......................................................................

Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter

Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Signed-off-by: Igor Lvovsky 
---
M vdsm/clientIF.py
M vdsm/configNetwork.py
M vdsm/netinfo.py
3 files changed, 53 insertions(+), 49 deletions(-)

Approvals:
  oVirt Jenkins CI Server: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6893
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: oVirt Jenkins CI Server