Change in vdsm[master]: (Schema) Minor corrections for IscsiPortal

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Minor corrections for IscsiPortal
......................................................................

(Schema) Minor corrections for IscsiPortal

Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/6844/1
--
To view, visit http://gerrit.ovirt.org/6844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Minor corrections for IscsiPortal
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2291: {'type': 'IscsiPortal', 'data': {'host': 'str', '*port': 'uint16'}}
So far we haven't been differentiating between integer sizes.  Instead the schema tries to stick to JSON-like types.  I can see the merits of specifying the integer size though.  I guess this raises a broader question, do we want to use JSON types in the schema or more specific vala types?

--
To view, visit http://gerrit.ovirt.org/6844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli

Saggi Mizrahi has abandoned this change.

Change subject: (Schema) Minor corrections for IscsiPortal
......................................................................

Patch Set 2: Abandoned

--
To view, visit http://gerrit.ovirt.org/6844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi