Change in vdsm[master]: added mtu support for network interface

Shahar Havivi has uploaded a new change for review.

Change subject: added mtu support for network interface
......................................................................

added mtu support for network interface

Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
---
M vdsm/configNetwork.py
1 file changed, 107 insertions(+), 15 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/754/1
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(8 inline comments)

incomplete review, ETOOTIRED.

....................................................
File vdsm/configNetwork.py
Line 238:     def addVlan(self, vlanId, iface, bridge, mtu=None):
we should read/test whether MTU here (and in the bridge conttected to this) includes the 4 byte vlan tag

Line 245:                 f.write('MTU=%s\n' % mtu)
quote

Line 282:                 f.write('MTU=%s\n' % mtu)
better safe than sorry - let's quote mtu, too.

Line 312:         ''' method returns entry value or None
Search entry in conffile and return its value or None if not found.

Line 313:             if we have MTU=9000 and we get 'MTU' as ethry
ethry->entry

Line 316:                     if line.upper().startswith(entry.upper() + '=') ]
why upper()? case is significant in ifcfg-*

Line 324:     def _updateConfigValue(self, conffile, entry, value, delete=False):
all these functions just cry "use augeas", please take a look.

Line 332:             f.writelines(entries)
this write is not atomic, and does not record a back backup file.

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 2: (5 inline comments)

....................................................
File vdsm/configNetwork.py
Line 245:                 f.write('MTU=%s\n' % mtu)
Done

Line 282:                 f.write('MTU=%s\n' % mtu)
Done

Line 312:         ''' method returns entry value or None
Done

Line 313:             if we have MTU=9000 and we get 'MTU' as ethry
Done

Line 316:                     if line.upper().startswith(entry.upper() + '=') ]
Done

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 2: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 324:     def _updateConfigValue(self, conffile, entry, value, delete=False):
its not part of RHEL (only epel)

Line 332:             f.writelines(entries)
Done

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 238:     def addVlan(self, vlanId, iface, bridge, mtu=None):
no need for that

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Saggi Mizrahi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 223:             s = s + 'MTU=%s\n' % pipes.quote(mtu)
Use %d, we do want it to fail if it's not a number

Line 312:         ''' method Search entry in conffile and return 
Rouge space

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 3: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 223:             s = s + 'MTU=%s\n' % pipes.quote(mtu)
ok, and this makes quote() redundant, too.

Line 260:                 f.write('MTU=%s\n' % mtu)
Saggi's right, with %d we don't need quote

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 3: (4 inline comments)

....................................................
File vdsm/configNetwork.py
Line 223:             s = s + 'MTU=%s\n' % pipes.quote(mtu)
Done

Line 223:             s = s + 'MTU=%s\n' % pipes.quote(mtu)
Done

Line 260:                 f.write('MTU=%s\n' % mtu)
Done

Line 312:         ''' method Search entry in conffile and return 
Done

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 4:

The backend needs the mtu reported in VdsCaps. If not 
reported by the ifcfg file please report the default

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 5: Verified; No score

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Mark Wu has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm/netinfo.py
Line 61:     mtu = file('/sys/class/net/%s/mtu' % iface).readline()
I think we need strip the '\n' with rstrip()

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File vdsm/netinfo.py
Line 61:     mtu = file('/sys/class/net/%s/mtu' % iface).readline()
Done

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 6: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 6: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 332:                     if line.startswith(entry + '=') ]
You may want to consider to:
- use strip() to remove any white character from the beginning/end of the line
- use split("=", 1) to split key/values (so you can avoid the startswith/[len(entry)+1:])
- use "with open(conffile)" to read the file

(Use the same suggestions for _updateConfigValue)

Line 548:                            gateway=gateway, **options)
Looks like addBridge/addVlan/addBonding/addNic are low level enough to assume that "mtu" value is correct. Therefore I would:
- get rid of all the "int(mtu)" in addBridge/addVlan/addBonding/addNic
- validate the mtu value only at the beginning of addNetwork (returning a descriptive error when needed)

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 6: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 332:                     if line.startswith(entry + '=') ]
Done

Line 548:                            gateway=gateway, **options)
Done

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 7: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 7: I would prefer that you didn't submit this

(2 inline comments)

two minor comments.

....................................................
File vdsm/configNetwork.py
Line 369:         ''' method checks to see if the current bridge has MTU
docstring text should look like

"""Update MTU for devices that are to remain after "bridge" is removed

method checks to see if the current bridge has MTU .... etcetc

Line 561:         configWriter.addBonding(bonding, ifaceBridge, bondingOptions=bondingOptions, mtu=mtu)
you should not reduce bonding mtu, too!

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 8: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Peter V. Saveliev has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 8: (2 inline comments)

sorry man, serious stuff this time.

....................................................
File vdsm/BindingXMLRPC.py
Line 314:     def addNetwork(self, bridge, vlan=None, bond=None, nics=None, mtu=None, options={}):
sorry for considering this only now, but this would break backward compatibility - old Engines would send "options" in this position. we have no choice but to throw mtu into the existing options dictionary.

Line 316:         return api.addNetwork(bridge, vlan, bond, nics, mtu, options={})
I'd do the same here (even there's no bc problems yet)

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 8: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 9: Verified

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: added mtu support for network interface
......................................................................

added mtu support for network interface

Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
---
M vdsm/configNetwork.py
M vdsm/netinfo.py
2 files changed, 166 insertions(+), 19 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................

Patch Set 9: Looks good to me, approved

Let's keep this review process as a single-digit iterations number.

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi