Change in vdsm[ovirt-3.6]: lvm: Use udev cache for obtaining device list

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47810

to review the following change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

lvm: Use udev cache for obtaining device list

Due to udev issues, the udev cache was ignored when obtaining
the device list.
Since these issues are fixed in Fedora 21 and RHEL 7, the lvm
configuration can be reverted to use the udev cache.

Original bug : https://bugzilla.redhat.com/1014942

Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Bug-Url: https://bugzilla.redhat.com/1272027
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/47430
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/47810/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 5b1abb0..aab4bc6 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -110,7 +110,6 @@
 ignore_suspended_devices=1
 write_cache_state=0
 disable_after_error_count=3
-obtain_device_list_from_udev=0
 %s
 }

[e-mail] has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1:

* Update tracker::#1272027::OK
* Check Bug-Url::OK
* Check Public Bug::#1272027::OK, public bug
* Check Product::#1272027::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Freddy Rolland has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1: Verified+1

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1: Code-Review+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1: Code-Review+1

The jenkins failure is not related, this test is skiped in master

Francesco Romani has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1: Code-Review+2

Francesco Romani has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 1:

now that jenkins' approved this patch, let's take it in.

Francesco Romani has submitted this change and it was merged.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

lvm: Use udev cache for obtaining device list

Due to udev issues, the udev cache was ignored when obtaining
the device list.
Since these issues are fixed in Fedora 21 and RHEL 7, the lvm
configuration can be reverted to use the udev cache.

Original bug : https://bugzilla.redhat.com/1014942

Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Bug-Url: https://bugzilla.redhat.com/1272027
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/47430
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47810
Reviewed-by: Allon Mureinik 
Reviewed-by: Francesco Romani 
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved
  Freddy Rolland: Verified

[e-mail] has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
......................................................................

Patch Set 2:

* Update tracker::#1272027::OK
* Set MODIFIED::bug 1272027::::#1272027::::IGNORE, not oVirt prod but vdsm