Change in vdsm[master]: Related to BZ#773210 - Avoid infinite loop when delete volum...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................

Related to BZ#773210 - Avoid infinite loop when delete volume failed during the merge.

This loop occurs at the end of the merge operation and if we failed
to remove remnants at this point it's still OK.

Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 5 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/3774/1
--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has submitted this change and it was merged.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................


Related to BZ#773210 - Avoid infinite loop when delete volume failed during the merge.

This loop occurs at the end of the merge operation and if we failed
to remove remnants at this point it's still OK.

Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 5 insertions(+), 13 deletions(-)

Approvals:
  Dmitry Fleytman: Verified
  Eduardo: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve
  Igor Lvovsky: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dmitry Fleytman <dmfleytman(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dmitry Fleytman <dmfleytman(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Dmitry Fleytman has posted comments on this change.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dmitry Fleytman <dmfleytman(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed
during the merge.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

May be better to catch something else than exception in merge.

--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;