Petr Horáček has uploaded a new change for review.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
tests: networkTests: use addrAdd instead of dummy.setIP
dummy.setIP was removed in 270caa05edaa56e93e188d35c4db7770f0ef42d8. Use addrAdd directly instead.
Change-Id: I15e515b0f092546eca5fc67b049fe9f5a1e0785b Signed-off-by: Petr Horáček phoracek@redhat.com --- M tests/functional/networkTests.py 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/47316/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index f0262ae..bb97a9a 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -2787,8 +2787,8 @@ def test_remove_initial_network_nic_ip_config(self): with dummyIf(1) as nics: nic, = nics - dummy.setIP(nic, IP_ADDRESS, IP_CIDR) - dummy.setIP(nic, IPv6_ADDRESS, IPv6_CIDR, family=6) + addrAdd(nic, IP_ADDRESS, IP_CIDR) + addrAdd(nic, IPv6_ADDRESS, IPv6_CIDR, family=6) try: status, msg = self.setupNetworks( {NETWORK_NAME: {'nic': nic, 'bridged': True}}, {}, NOCHK) @@ -2811,8 +2811,8 @@ def test_keep_initial_bond_slaves_ip_config(self): with dummyIf(2) as nics: nic_1, nic_2 = nics - dummy.setIP(nic_1, IP_ADDRESS, IP_CIDR) - dummy.setIP(nic_1, IPv6_ADDRESS, IPv6_CIDR, family=6) + addrAdd(nic_1, IP_ADDRESS, IP_CIDR) + addrAdd(nic_1, IPv6_ADDRESS, IPv6_CIDR, family=6) try: status, msg = self.setupNetworks( {}, {BONDING_NAME: {'nics': [nic_1, nic_2]}}, NOCHK)
automation@ovirt.org has posted comments on this change.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Petr Horáček has posted comments on this change.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
Patch Set 1: Verified+1
test_keep_initial_bond_slaves_ip_config and test_remove_initial_network_nic_ip_config passed
Dan Kenigsberg has posted comments on this change.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
tests: networkTests: use addrAdd instead of dummy.setIP
dummy.setIP was removed in 270caa05edaa56e93e188d35c4db7770f0ef42d8. Use addrAdd directly instead.
Change-Id: I15e515b0f092546eca5fc67b049fe9f5a1e0785b Signed-off-by: Petr Horáček phoracek@redhat.com Reviewed-on: https://gerrit.ovirt.org/47316 Reviewed-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Jenkins CI --- M tests/functional/networkTests.py 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: tests: networkTests: use addrAdd instead of dummy.setIP ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org