Change in vdsm[master]: closing file after writing

Yaniv Bronhaim has uploaded a new change for review.

Change subject: closing file after writing
......................................................................

closing file after writing

Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/vdsm
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/15254/1

diff --git a/vdsm/vdsm b/vdsm/vdsm
index 96e657d..fef86db 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -83,7 +83,8 @@
 
         pidfile = constants.P_VDSM_RUN + 'vdsmd.pid'
         pid = str(os.getpid())
-        file(pidfile, 'w').write(pid + "\n")
+        with open(pidfile, 'w') as f:
+            f.write(pid + "\n")
         os.chmod(pidfile, 0664)
 
         sysname, nodename, release, version, machine = os.uname()


--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Yaniv Bronhaim has posted comments on this change.

Change subject: closing file after writing
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: closing file after writing
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: closing file after writing
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: closing file after writing
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2498/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1670/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2569/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: closing file after writing
......................................................................


closing file after writing

Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/vdsm
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id328e1482680959ebb55eddc28615e6d6be1545b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server