Edward Haas has posted comments on this change.
Change subject: net: early IP+link setup
......................................................................
Patch Set 19: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/60371/19/lib/vdsm/network/netrestore.py
File lib/vdsm/network/netrestore.py:
Line 23: import os
Line 24:
Line 25: import six
Line 26:
Line 27: from vdsm.common.contextlib import suppress
Needs to be done though 'compat'.
from vdsm.compat import contextlib
Line 28: from vdsm.config import config
Line 29: from vdsm.constants import P_VDSM_RUN
Line 30: from vdsm.utils import tobool
Line 31:
Line 58:
Line 59: bonds = _persisted_ovs_entries(persistent_config.bonds)
Line 60: logging.info('Restoring bondings configuration: {}'.format(bonds))
Line 61:
Line 62: _setup_ipv6autoconf(nets)
Why not just do it directly like this:
for net, netattr in six.iteritems(nets):
with suppress(Exception):
netswitch.setup_ipv6autoconf({net: netattr})
Same for the rest...
Line 63: _set_links_up(nets, bonds, {})
Line 64: _setup_ip_config(nets, {})
Line 65:
Line 66: logging.info('Initial network setup is done.')
--
To view, visit
https://gerrit.ovirt.org/60371
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes