Change in vdsm[master]: Replace most traceback.format_exc() calls by exc_info

Ewoud Kohl van Wijngaarden has uploaded a new change for review.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................

Replace most traceback.format_exc() calls by exc_info

Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_qualifier.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/storage/misc.py
M vdsm/storage/storage_mailbox.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_reg/vdsm-gen-cert
M vdsm_reg/vdsm-reg-setup.in
16 files changed, 56 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/2259/1
--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File vdsm/storage/misc.py
Line 150:     log.error("Panic: %s", msg, exc_info=True)
thanks for cleaning this up.

....................................................
File vdsm/storage/storage_mailbox.py
Line 443:                             "monitoring thread caught exception; " \
trailing backslashes are redundant in parenthesis

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

Adam Litke has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

Adam Litke has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/misc.py
Line 150:     log.error("Panic: %s" % (str(msg)), exc_info=True)
%

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

Adam Litke has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/utils.py
Line 127:                     logging.debug("Could not read %s" % f,
exc_info=True)
Oops, here is another '%'

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

Adam Litke has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 1: (1 inline comment)

Please address my comment but other than that it looks good to me.

....................................................
File vdsm/utils.py
Line 134:                             (f, s), exc_info=True)
Don't use the '%' operator in log messages because it incurs the formatting
overhead whether or not the code path is even executed.  You should just be able to pass f
and s as parameters and the logger will format the message on-demand.

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Replace most traceback.format_exc() calls by exc_info

Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_qualifier.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/storage/misc.py
M vdsm/storage/storage_mailbox.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_reg/vdsm-gen-cert
M vdsm_reg/vdsm-reg-setup.in
16 files changed, 70 insertions(+), 77 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 4: Verified; Looks good to me, approved

trailing backslashes are even worse than trailing whitespace

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 2: (2 inline comments)

Thanks for the feedback, patch set 3 incoming.

....................................................
File vdsm/storage/misc.py
Line 150:     log.error("Panic: %s" % (str(msg)), exc_info=True)
This was already there, but since we're touching the line anyway I'll fix this. I
think the str() is also redundant.

....................................................
File vdsm/utils.py
Line 127:                     logging.debug("Could not read %s" % f,
exc_info=True)
Done

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;