Change in vdsm[master]: file_volume: Add qcow2_compat on create

[Maor Lipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

file_volume: Add qcow2_compat on create

Pass qcow2 compat on create.

Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/fileVolume.py
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/64374/1

diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index ad62eec..334c08c 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -434,7 +434,8 @@
                          "sectors", sc.type2name(volFormat), volPath,
                          size)
             if volFormat == sc.COW_FORMAT:
-                qemuimg.create(volPath, sizeBytes, sc.fmt2str(volFormat))
+                qemuimg.create(volPath, sizeBytes, sc.fmt2str(volFormat),
+                               qcow2_compat=dom.qcow2_compat())
         else:
             # Create hardlink to template and its meta file
             cls.log.info("Request to create snapshot %s/%s of volume %s/%s",

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 6:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

[Maor Lipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 6: Verified+1

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 7:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 8:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 9:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 10:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 11:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 12:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 13:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 14:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 15:

* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

[Maor Lipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 15: Verified+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 15: Code-Review+2

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 15: Continuous-Integration+1

Network tests errors again, ignoring.

[Nir Soffer]

Nir Soffer has submitted this change and it was merged.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

file_volume: Add qcow2_compat on create

Pass qcow2 compat on create.

Change-Id: I81fd3a6e263980c1eabeea7f619c9a6b48991938
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/64374
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/storage/fileVolume.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Maor Lipchuk: Verified

Objections:
  Jenkins CI: Failed CI tests

gerrit-hooks has posted comments on this change.

Change subject: file_volume: Add qcow2_compat on create
......................................................................

Patch Set 16:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.