11:06 a.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
vm tests: avoid leaving /tmp/blechs.recovery behind
There's code that expects P_VDSM_VAR_RUN to end with a slash.
Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/vmTests.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/26197/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 91bbefb..3f6f695 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -699,7 +699,7 @@
@contextmanager
def FakeVM(params=None):
with namedTemporaryDir() as tmpDir:
- with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir),
+ with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/'),
(libvirtconnection, 'get',
lambda x: ConnectionMock())]):
vmParams = {'vmId': 'TESTING'}
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
10:14 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
vm tests: avoid leaving /tmp/blechs.recovery behind
There's code that expects P_VDSM_VAR_RUN to end with a slash.
Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/26197
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/vmTests.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10:14 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
Patch Set 1: Verified+1 Code-Review+2
./run_tests.sh functional/vmTests.py no longer creates zillion .recovery files on /tmp.
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:10 a.m.
Francesco Romani has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
good enough for me, let's get rid of those annoying files on /tmp
http://gerrit.ovirt.org/#/c/26197/1/tests/vmTests.py
File tests/vmTests.py:
Line 701: namedTemporaryDir
After a bit of thinking, I'm starting to believe we should fix namedTemporaryDir
instead. Still not sure, so I'm OK with this patch.
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
11:09 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6922/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7712/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7824/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:40 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73e7628be87692d17a6a5f629c3370df37e22dc8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3696
days inactive
3703
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
fromani＠redhat.com -
Jenkins CI RO